[RFC14] Part 3: Define constraints inside the value type #667
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
libs/execution/src/lib/types/value-types/value-representation-validity.ts
Outdated
Show resolved
Hide resolved
libs/language-server/src/lib/ast/wrappers/value-type/atomic-value-type.ts
Outdated
Show resolved
Hide resolved
Comment on lines
+45
to
+46
| | ConstraintDefinition | ||
| | ValueTypeConstraintInlineDefinition |
There was a problem hiding this comment.
Future work: this could return a constraint wrapper instead
| props, | ||
| ); | ||
| if (isValueTypeConstraintInlineDefinition(constraint)) { | ||
| checkConstraintExpression(constraint.expression, props); |
There was a problem hiding this comment.
Do we check somewhere that the attribute we refer to in the inline constraint exists?
There was a problem hiding this comment.
No, we don't, but neither for inline definitions nor external definitions.
The code snippets
valuetype VT {
property id oftype text;
constraint exactlyTenCharacters: lengthof unknown == 10;
}
valuetype VT {
property id oftype text;
constraint len: ExactlyTenCharacters on id;
}
constraint ExactlyTenCharacters on text: lengthof unknown == 10;
both fail during execution with the same message
Could not resolve reference to Referencable named 'unknown'.
There was a problem hiding this comment.
Would be nice to catch this in a validation, so as a language server hint. But can be postponed to a follow-up PR
georg-schwarz
approved these changes
Jun 6, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Final part of implementing RFC14.
Continues #665.
This PR allows for constraints to be defined inside a value type.
Example of the new syntax: