8000 In stable docs, search icon (magnifying glass) in top nav doesn't display · Issue #751 · jupyter/jupyter · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

In stable docs, search icon (magnifying glass) in top nav doesn't display #751

New issue

Have a question about this project? 8000 Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mfisher87 opened this issue Dec 20, 2024 · 7 comments
Open

In stable docs, search icon (magnifying glass) in top nav doesn't display #751

mfisher87 opened this issue Dec 20, 2024 · 7 comments
Labels
documentation

Comments

@mfisher87
Copy link
mfisher87 commented Dec 20, 2024 •
edited
Loading

Resolved for latest docs by #737 but stable docs are still impacted.

The search button in the top nav bar displays with only a keyboard shortcut hint, and no icon:

https://docs.jupyter.org/en/stable/contributing/content-contributor.html

Image

I'm using Firefox 133.0. Also tested in Chromium 119 and the behavior is the same.

When I click the space where the search icon should be, the icon flashes into existence for a fraction of a second and disappears again! 🙈
@mfisher87
Copy link
Author

Now that I paste the screenshot, I see the search icon and text are there, but so dark they can't be easily seen.

@mfisher87 mfisher87 changed the title Search icon (magnifying glass) in top nav doesn't display In stable docs, search icon (magnifying glass) in top nav doesn't display Dec 20, 2024
@ivanov
Copy link
Member
ivanov commented Jan 9, 2025 •
edited
Loading

thanks for the report @mfisher87. I won't have a chance to push on this, but it's sound 8000 s like #709 either didn't get resolved or the problem came back. Maybe @melissawm has some ideas?

@melissawm
Copy link
Contributor

I think this just needs a backport? I'm not sure when you released stable but it seems like in between the last release of stable and now this problem had been going unnoticed. I think only a maintainer can do that, I'm afraid.

@ivanov
Copy link
Member
ivanov commented Jan 9, 2025 •
edited
Loading

oh, right, best I can tell there isn't an explicit version of pydata_sphinx_theme used by the docs build, so it will pull in the latest if we rebuild the stable docs. From the footer I can tell that stable uses PyData Sphinx Theme 0.15.4, whereas latest has 0.16.0.

In trying to trigger a rebuild, I figured out that as far as RTD is concerned, I'm not a "maintainer" of jupyter, so I can't actually access the administration option for the project to do this. 😅

So happy new year to minrk and Carreau! Could one of you go to https://app.readthedocs.org/dashboard/jupyter/users/create/ and add ivanov to that repo? then I can take care of the rebuild. <3 (also asked on zulip in case someone else sees that first)

(edit: taking off Min and Matthias' @ mentions, since Min hooked me up)

@ivanov
Copy link
Member
ivanov commented Jan 10, 2025 •
edited
Loading

Ok, stable docs rebuilding over at https://app.readthedocs.org/projects/jupyter/builds/26810243/ 🤞

welp - that build did pick up pydata theme 0.16.1, as the stable docs will now attest in the footer, so we had the correct understanding there, unfortunately it still looks as low-contrast as it did before, in dark mode.

@ivanov
Copy link
Member
ivanov commented Jan 10, 2025 •
edited
Loading

just dropping breadcrumbs for anyone else who can take a look at this, or my future self: a quick peek at the differences on the index.html reveals that stable is the only one that has sphinx-dropdown.css and panels-bootstrap.min.css , whereas latest is the only one that has sphinx-design.min.css, and also design-tabs.js.

@melissawm
Copy link
Contributor

ok! so this likely means that stable was built with sphinx-panels and latest was built with sphinx-design. The latter supersedes the former and it is in fact one of the changes I did in my PR - see https://github.com/jupyter/jupyter/pull/737/files

Could you try rebuilding with sphinx-design instead? Sorry I'm not able to do it myself, or I would!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ivanov @mfisher87 @melissawm
0