8000 icons invisible in dark mode · Issue #709 · jupyter/jupyter · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

icons invisible in dark mode #709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
brownsarahm opened this issue Oct 31, 2023 · 5 comments · Fixed by #737
Closed

icons invisible in dark mode #709

brownsarahm opened this issue Oct 31, 2023 · 5 comments · Fixed by #737

Comments

@brownsarahm
Copy link

In dark mode the search and dark/light mode on https://docs.jupyter.org/ are not visible until hover, they are visible on other projects though like https://jupyter-notebook.readthedocs.io/en/latest/

I'm in a managed chrome that does not allow any extensions.
Version 118.0.5993.117 (Official Build) (x86_64)

Screen Shot 2023-10-31 at 8 33 12 AM

Screen Shot 2023-10-31 at 8 33 58 AM
@amoghakancharla
Copy link
Contributor

I'd love to help on this issue, @brownsarahm. Please let me know if you've already started working on it.

@brownsarahm
Copy link
Author

I have not worked on this.

@ivanov
Copy link
Member
ivanov commented Nov 17, 2023

Thank you for the report. What operating system is this, by chance? I just tried on a similar version of chrome, and do not see this issue: Version 118.0.5993.70 (Official Build) built on Debian 12.2, running on Debian 12.2 (64-bit).

It's also possible that it has been fixed in the time that this was reported, at the bottom of either page you'll see what theme is being used, which currently reads

Built with the PyData Sphinx Theme 0.14.3.

If you are still seeing this issue, the proper place to report is over there: https://github.com/pydata/pydata-sphinx-theme/issues (and then we'll pick up those fixes in the various projects which use the pydata sphinx theme)

@brownsarahm
Copy link
Author

I still see this problem, the reason I reported here and not pydata-sphinx is because the problem exists on this site, but not others that are using the same version of the pydata sphinx theme, so I suspected it was a setting or possibly custom css in this repo causing the problem. The notebook docs linked above say they are using the same version of pydata theme, but on the same browser I can see.

I'm on macos (11.2.3 with 2.3 GHz Quad-Core Intel Core i7) and now on chrome Version 119.0.6045.123 (Official Build) (x86_64)

@ivanov
Copy link
Member
ivanov commented Nov 17, 2023

interesting - and weirdly, I now also see the problem you report on https://docs.jupyter.org/

@melissawm melissawm mentioned this issue Sep 8, 2024
Merged
@ivanov ivanov mentioned this issue Jan 9, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix documentation site display and a few warnings melissawm/jupyter
3 participants
@ivanov @brownsarahm @amoghakancharla
0