8000 Use of std::size_t by adambadura · Pull Request #3 · irrequietus/typestring · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Use of std::size_t #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch 8000
from
Open

Use of std::size_t #3

wants to merge 2 commits into from

Conversation

adambadura
Copy link

Changes for #2.

Along the way I have also corrected tygrab in similar way. There it seems that N (the index, first template argument) would be better std::ptrdiff_t type. However that would result in mixing signed and unsigned types in same expression. While there is no real benefit as we will never use negative index anyway.

I also wonder why tygrap uses the ternary expression to make upper bound of the index. It seems static_assert would be better. Or is there a use case for such behaviour? Anyway it seems a separate topic so I didn't do anything about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henrygab henrygab henrygab approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adambadura @henrygab
0