8000 Fix padding reading in TypedPropertyValue by hughbe · Pull Request #74 · ironfede/openmcdf · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix padding reading in TypedPropertyValue #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 23, 2023
Merged

Fix padding reading in TypedPropertyValue #74

merged 1 commit into from
Apr 23, 2023

Conversation

hughbe
Copy link
Contributor
@hughbe hughbe commented Nov 5, 2020
  • E.g. If the start position is 0 and the end position is 13, then size = 13-0=13, m = (int)size % 4=1, so we don't need m bytes of padding, but actually 4

@ironfede
Copy link
Owner

Thank you @hughbe and sorry for delayed response.
I will include it in next release of Extensions package. Btw I've noticed that your comment should be "...actually 4 -m " since this is the change you've correctly implemented in PR.
Many thanks,
Federico

@ironfede ironfede merged commit cee9924 into ironfede:master Apr 23, 2023
@hughbe hughbe deleted the patch-1 branch April 24, 2023 06:48
@Numpsy Numpsy mentioned this pull request Sep 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hughbe @ironfede
0