Fix object disposal in tests #173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Catching the exception makes it harder to debug/fix failures
File system operations are inherently racy, so File.Delete already does nothing if the file does not exist.
Goes some way to addressing the analyzer warning: CA2000: Dispose objects before losing scope
|
@ironfede In the absence of PR triggers for CI, I have tested these ones manually on Ubuntu 24.04 too! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The counterpart to fixing CA2000 in the core library, this fixes some more test implementation logic (e.g. more Assert.ThrowsException, etc.), removes redundant code, and fixes CA2000 for the tests