8000 2.4 API additions by jeremy-visionaid · Pull Request #169 · ironfede/openmcdf · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

2.4 API additions #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 2, 2024
Merged

Conversation

jeremy-visionaid
Copy link
Collaborator

Adds the following methods:

  • CompoundFile.Dispose (as public)
  • ContainsStream
  • ContainsStorage
  • TryDelete

While adding them, I found some problems with the existing implementation that I have fixed since it made sense to do so at the same time:

  • RBTreeEnumerator performed multiple enumeration on a Queue via LINQ, but RBTree did not support LINQ (IEnumerable)
  • Directory resets invloved multiple redundant casts and lookups

Allow disposal without a cast
Allow checking to see whether a particular Stream or Storage already exists
Implement IEnumerable<T> to allow generic enumeration.

Also use a List for the enumerator to avoid internal multiple
enumeration with LINQ. (i.e. don't use ElementAt)
Also, avoid redundant casts and lookups
@ironfede ironfede merged commit b4214ee into ironfede:master Oct 2, 2024
@jeremy-visionaid jeremy-visionaid deleted the 2.4-api branch October 16, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0