Always populate UserDefinedProperties.PropertyNames when reading a file with UserDefined properties, and add a read/write user property test #117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Numpsy
commented
Feb 27, 2024
| .Where(p => p.PropertyType == PropertyType.DictionaryProperty).FirstOrDefault()?.Value; | ||
|
|
||
| UserDefinedProperties.PropertyNames = existingPropertyNames ?? new Dictionary<uint, string> (); |
There was a problem hiding this comment.
The test file 'english.presets.doc' contains a UserDefinedProperties section, but it doesn't contain a dictionary property, which as it stands prevents a user from adding new properties to the existing section.
The Microsoft documentation at https://learn.microsoft.com/en-us/openspecs/office_file_formats/ms-oshared/1414f765-ea8e-4a1e-a19c-641500e5f93d says that the UserDefinedProperty section MUST have a dictionary property so I'm not sure why this file doesn't have one, but - If it must be there then i think it's reasonable to always have PropertyNames set to a not-null value for the UserDefined property section?
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #104 and #106 (comment)