[Codegen] Propagate relayout ops before combining #20901
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3fcac51 to
3df8a6f
Compare
hanhanW
reviewed
May 28, 2025
compiler/src/iree/compiler/Codegen/Common/CombineLayoutTransformation.cpp
Outdated
Show resolved
Hide resolved
compiler/src/iree/compiler/Codegen/Common/CombineLayoutTransformation.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Max Dawkins <max.dawkins@gmail.com>
Signed-off-by: Max Dawkins <max.dawkins@gmail.com>
3df8a6f to
3fa14b9
Compare
hanhanW
approved these changes
May 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds propagation patterns to CombineLayoutTransformation before introducing any map_scatter ops in order to push relayout ops towards the end of the dispatch. There can be compute ops between sequences of relayout ops, which block further folding of relayout ops into the map_scatter, so the propagation can expose additional folding opportunities. Propagation is currently restricted to cases where additional pack operations will not be introduced on the operands of compute ops.
This PR will help to enable some consumer fusions, like elementwise truncations, in the data tiling fusion path.