[LinalgExt] Canonicalize gather to an extract_slice #20878
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Wood <ianwood2024@u.northwestern.edu>
hanhanW
reviewed
May 21, 2025
compiler/src/iree/compiler/Dialect/LinalgExt/IR/LinalgExtOps.cpp
Outdated
Show resolved
Hide resolved
compiler/src/iree/compiler/Dialect/LinalgExt/IR/LinalgExtOps.cpp
Outdated
Show resolved
Hide resolved
compiler/src/iree/compiler/Dialect/LinalgExt/IR/LinalgExtOps.cpp
Outdated
Show resolved
Hide resolved
compiler/src/iree/compiler/Dialect/LinalgExt/IR/test/canonicalize.mlir
Outdated
Show resolved
Hide resolved
compiler/src/iree/compiler/Dialect/LinalgExt/IR/test/canonicalize.mlir
Outdated
Show resolved
Hide resolved
Signed-off-by: Ian Wood <ianwood2024@u.northwestern.edu>
Signed-off-by: Ian Wood <ianwood2024@u.northwestern.edu>
hanhanW
approved these changes
May 21, 2025
ziereis
pushed a commit
to ziereis/iree
that referenced
this pull request
May 22, 2025
Adds canonicalizer to `iree_linalg_ext.gather` to convert to a `tensor.extract_slice` when there is only a single contiguous slice gathered by the op (aka a single batch of indices). Also, I had to fixup `compiler/src/iree/compiler/DispatchCreation/test/pipeline_tests.mlir` so that the gathers didn't get converted. --------- Signed-off-by: Ian Wood <ianwood2024@u.northwestern.edu> Signed-off-by: Thomas Ziereis <ziereis@roofline.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds canonicalizer to
iree_linalg_ext.gatherto convert to atensor.extract_slicewhen there is only a single contiguous slice gathered by the op (aka a single batch of indices).Also, I had to fixup
compiler/src/iree/compiler/DispatchCreation/test/pipeline_tests.mlirso that the gathers didn't get converted.