8000 Cleaning up iree_hal_module_debug_sink_t destroy. by benvanik · Pull Request #20841 · iree-org/iree · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Cleaning up iree_hal_module_debug_sink_t destroy. #20841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 16, 2025

Conversation

benvanik
Copy link
Collaborator

It was not properly added to the inline HAL, did not handle the status, and was misnamed for what it was doing (destroy = delete). It's still not great that this grew this method but it was confusing as it was. If debug sinks need lifetime management they should be promoted to a full ref counted type instead of an on-stack by-value struct as was the original intent.

It was not properly added to the inline HAL, did not handle the status,
and was misnamed for what it was doing (destroy = delete).
@benvanik benvanik force-pushed the users/benvanik/debug-sink-cleanup branch from 8526d6b to f0982fb Compare May 16, 2025 18:53
@benvanik benvanik enabled auto-merge (squash) May 16, 2025 19:16
@benvanik benvanik merged commit f9d892a into main May 16, 2025
46 checks passed
@benvanik benvanik deleted the users/benvanik/debug-sink-cleanup branch May 16, 2025 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0