Cleaning up iree_hal_module_debug_sink_t destroy. #20841
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was not properly added to the inline HAL, did not handle the status, and was misnamed for what it was doing (destroy = delete).
8526d6b to
f0982fb
Compare
ScottTodd
approved these changes
May 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was not properly added to the inline HAL, did not handle the status, and was misnamed for what it was doing (destroy = delete). It's still not great that this grew this method but it was confusing as it was. If debug sinks need lifetime management they should be promoted to a full ref counted type instead of an on-stack by-value struct as was the original intent.