[Im2col] Fix bug when there is no batch dimension #20711
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yzhang93 <zhyuhang88@gmail.com>
f1cc990 to
896d94e
Compare
Max191
approved these changes
May 2, 2025
nirvedhmeshram
pushed a commit
that referenced
this pull request
May 6, 2025
This PR fixes a bug introduced in #20633, that when `getBatchPos()` is empty, `getBatchPos().front()` will cause a crash. Move it inside the condition of `contiguousAlongB`, since this condition guarantees the batch dimension is non-empty. Signed-off-by: yzhang93 <zhyuhang88@gmail.com>
KyleHerndon
pushed a commit
to KyleHerndon/iree
that referenced
this pull request
May 7, 2025
This PR fixes a bug introduced in iree-org#20633, that when `getBatchPos()` is empty, `getBatchPos().front()` will cause a crash. Move it inside the condition of `contiguousAlongB`, since this condition guarantees the batch dimension is non-empty. Signed-off-by: yzhang93 <zhyuhang88@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug introduced in #20633, that when
getBatchPos()is empty,getBatchPos().front()will cause a crash. Move it inside the condition ofcontiguousAlongB, since this condition guarantees the batch dimension is non-empty.