[DispatchCreation] Relax unit dim expansion cycle check #20781
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IanWood1
reviewed
May 12, 2025
|
|
||
| // Check for multiple uses. The producer has at least 1 use: the | ||
| // expand_shape. | ||
| if (numUnitDimExpands >= outputShape.size() - 1 && isMultiUse) { |
There was a problem hiding this comment.
isMultiUse should always be true here
| } | ||
| // Check if the output shape of reassociations is only doing unit dim | ||
| // expands. | ||
| int64_t numUnitDimExpands = |
There was a problem hiding this comment.
Should we also check that all of the re-associations are only unit dim expands? i.e. convert the for loop into an llvm::all_of
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot
2CDF
be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cycle check was also restricting non unit dim expansions. This patch allows one iteration of the cycle to happen, which will lead to only a unit dim expand and changes the check to restrict this unit dim expand.