[Codegen] Drop read_only from LoadFromMemrefOp. #20693
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hanhanW <hanhan0912@gmail.com>
|
I kinda want to keep a marker of read only somewhere so we can shove |
We need to keep a single source of truth of where the read only information comes. It would be very easy for things to be out of sync. |
MaheshRavishankar
approved these changes
May 1, 2025
In the current use cases, you can always track the SSA chain back to bindings and figure it out. Unless you have a different use case, we don't need this at all.
Mahesh also has a valid concern. |
Max191
approved these changes
May 1, 2025
nirvedhmeshram
pushed a commit
that referenced
this pull request
May 6, 2025
The operand was added for bufferization, which is not used in the implementation. The revision drops the unused argument. Signed-off-by: hanhanW <hanhan0912@gmail.com>
KyleHerndon
pushed a commit
to KyleHerndon/iree
that referenced
this pull request
May 7, 2025
The operand was added for bufferization, which is not used in the implementation. The revision drops the unused argument. Signed-off-by: hanhanW <hanhan0912@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The operand was added for bufferization, which is not used in the implementation. The revision drops the unused argument.