Properly handle unaligned refs in VM ABI marshaling. #20671
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6084c8c to
779b1a9
Compare
iree_vm_ref_* functions have been updated to handle unaligned ref pointers. The changes do not significantly change the code and allow for the ABI marshaling to remain simple. Tests were added to verify the ABI size calculations match expectations. A bug was fixed in padding of i64/f64 argument registers on external calls both in the compiler and runtime. Fixes #20663.
779b1a9 to
abf79f8
Compare
|
@benvanik , i am unfamiliar with this code and would need a video chat to bring me up to speed if i'm going to do a review here. |
benvanik
commented
Apr 30, 2025
compiler/src/iree/compiler/Dialect/VM/Analysis/RegisterAllocation.cpp
Outdated
Show resolved
Hide resolved
nirvedhmeshram
pushed a commit
that referenced
this pull request
May 6, 2025
`iree_vm_ref_*` functions have been updated to handle unaligned ref pointers. The changes do not significantly change the code and allow for the ABI marshaling to remain simple. Tests were added to verify the ABI size calculations match expectations. A bug was fixed in padding of i64/f64 argument registers on external calls both in the compiler and runtime. Fixes #20663.
KyleHerndon
pushed a commit
to KyleHerndon/iree
that referenced
this pull request
May 7, 2025
`iree_vm_ref_*` functions have been updated to handle unaligned ref pointers. The changes do not significantly change the code and allow for the ABI marshaling to remain simple. Tests were added to verify the ABI size calculations match expectations. A bug was fixed in padding of i64/f64 argument registers on external calls both in the compiler and runtime. Fixes iree-org#20663.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
iree_vm_ref_*functions have been updated to handle unaligned ref pointers. The changes do not significantly change the code and allow for the ABI marshaling to remain simple.Tests were added to verify the ABI size calculations match expectations.
A bug was fixed in padding of i64/f64 argument registers on external calls both in the compiler and runtime.
Fixes #20663.