8000 [DataTiling] Add matmul_k option to SetEncoding pass. by pashu123 · Pull Request #20529 · iree-org/iree · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[DataTiling] Add matmul_k option to SetEncoding pass. #20529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 14, 2025
Merged

[DataTiling] Add matmul_k option to SetEncoding pass. #20529

merged 5 commits into from
Apr 14, 2025

Conversation

pashu123
Copy link
Contributor

No description provided.

@pashu123 pashu123 changed the title [Encoding] Add the matmul k attribute [Encoding] Add the matmul k encoding attribute Apr 11, 2025
@pashu123 pashu123 marked this pull request as ready for review April 11, 2025 20:49
hanhanW
hanhanW previously approved these changes Apr 11, 2025
View reviewed changes
@hanhanW hanhanW dismissed their stale review April 11, 2025 21:12

I clicked wrong button..

@pashu123 pashu123 force-pushed the encodingk branch 2 times, most recently from 027f4ed to a60947b Compare April 14, 2025 17:17
@pashu123 pashu123 changed the title [Encoding] Add the matmul k encoding attribute [Encoding] Set the matmul k encoding attribute Apr 14, 2025
@pashu123 pashu123 requested a review from hanhanW April 14, 2025 17:26
hanhanW
hanhanW requested changes Apr 14, 2025
View reviewed changes
Copy link
Contributor
@hanhanW hanhanW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need two global flags to enable it in the pipeline.

iree/compiler/src/iree/compiler/GlobalOptimization/Passes.cpp

Lines 178 to 179 in 7724306

FunctionLikeNest(mainPassManager)
.addPass(DispatchCreation::createSetEncodingPass);

iree/compiler/src/iree/compiler/DispatchCreation/Passes.cpp

Line 247 in 7724306

.addPass(createSetEncodingPass)

@pashu123 pashu123 requested a review from hanhanW April 14, 2025 21:37
hanhanW
hanhanW approved these changes Apr 14, 2025
View reviewed changes
Copy link
Contributor
@hanhanW hanhanW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, just one nit about comment and naming and one revert request for final.

@hanhanW hanhanW changed the title [Encoding] Set the matmul k encoding attribute [DataTiling] Add matmul_k option to SetEncoding pass. Apr 14, 2025
@hanhanW hanhanW merged commit a802470 into iree-org:main Apr 14, 2025
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
6A73

@hanhanW hanhanW hanhanW approved these changes

@MaheshRavishankar MaheshRavishankar Awaiting requested review from MaheshRavishankar MaheshRavishankar is a code owner

@IanWood1 IanWood1 Awaiting requested review from IanWood1 IanWood1 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pashu123 @hanhanW
0