Deprecate --iree-codegen-gpu-native-math-precision
#20299
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanhanW
approved these changes
Mar 18, 2025
Signed-off-by: Benoit Jacob <jacob.benoit.1@gmail.com>
091d76e to
c71e275
Compare
|
Anyone finding this from the new warning on ROCm: you can almost certainly go ahead and just drop the |
Eliasj42
pushed a commit
that referenced
this pull request
Mar 24, 2025
This was mostly used on ROCm and WebGPU. On ROCm, over the past month we have made this be essentially the default behavior, so the flag is essentially not needed anymore. The last thing required before we can drop usage of the flag on ROCm is #20074. On WebGPU, this PR makes this be the default behavior like on ROCm, so this PR also drops the flag. The WGSL spec issue gpuweb/gpuweb#5109 mentioned in the comment explains the problem. It has also been discussed in the past as #11321. Signed-off-by: Benoit Jacob <jacob.benoit.1@gmail.com> Signed-off-by: Elias Joseph <eljoseph@amd.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was mostly used on ROCm and WebGPU.
On ROCm, over the past month we have made this be essentially the default behavior, so the flag is essentially not needed anymore. The last thing required before we can drop usage of the flag on ROCm is #20074.
On WebGPU, this PR makes this be the default behavior like on ROCm, so this PR also drops the flag. The WGSL spec issue gpuweb/gpuweb#5109 mentioned in the comment explains the problem. It has also been discussed in the past as #11321.