8000 Move ASM to the end of languages list in CMakeLists.txt by javidcf · Pull Request #19781 · iree-org/iree · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Move ASM to the end of languages list in CMakeLists.txt #19781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 30, 2025

Conversation

javidcf
Copy link
Contributor
@javidcf javidcf commented Jan 23, 2025

This allows CMake to check whether the C/C++ compiler can compile ASM.

As per the documetation of CMake (project, enable_language):

If enabling ASM, list it last so that CMake can check whether compilers for other languages like C work for assembly too.

For more information see CMake issue #17532.

This allows CMake to check whether the C/C++ compiler can compile ASM.

Signed-off-by: Javier Dehesa <javidcf@gmail.com>
@benvanik benvanik self-requested a review April 30, 2025 00:59
@benvanik
Copy link
Collaborator

Good catch, thanks for the patch!

@benvanik benvanik enabled auto-merge (squash) April 30, 2025 01:01
@benvanik benvanik merged commit e7f33bc into iree-org:main Apr 30, 2025
57 of 60 checks passed
KyleHerndon pushed a commit to KyleHerndon/iree that referenced this pull request May 7, 2025
This allows CMake to check whether the C/C++ compiler can compile ASM.

As per the documetation of CMake
([`project`](https://cmake.org/cmake/help/latest/command/project.html),
[`enable_language`](https://cmake.org/cmake/help/latest/command/enable_language.html)):

> If enabling `ASM`, list it last so that CMake can check whether
compilers for other languages like `C` work for assembly too.

For more information see [CMake issue
iree-org#17532](https://gitlab.kitware.com/cmake/cmake/-/issues/17532).

Signed-off-by: Javier Dehesa <javidcf@gmail.com>
Co-authored-by: Ben Vanik <ben.vanik@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0