Move ASM to the end of languages list in CMakeLists.txt #19781
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows CMake to check whether the C/C++ compiler can compile ASM. Signed-off-by: Javier Dehesa <javidcf@gmail.com>
|
Good catch, thanks for the patch! |
benvanik
approved these changes
Apr 30, 2025
KyleHerndon
pushed a commit
to KyleHerndon/iree
that referenced
this pull request
May 7, 2025
This allows CMake to check whether the C/C++ compiler can compile ASM. As per the documetation of CMake ([`project`](https://cmake.org/cmake/help/latest/command/project.html), [`enable_language`](https://cmake.org/cmake/help/latest/command/enable_language.html)): > If enabling `ASM`, list it last so that CMake can check whether compilers for other languages like `C` work for assembly too. For more information see [CMake issue iree-org#17532](https://gitlab.kitware.com/cmake/cmake/-/issues/17532). Signed-off-by: Javier Dehesa <javidcf@gmail.com> Co-authored-by: Ben Vanik <ben.vanik@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows CMake to check whether the C/C++ compiler can compile ASM.
As per the documetation of CMake (
project,enable_language):For more information see CMake issue #17532.