[IR-10447] Rework image loading limits on iOS #2070
+240
−89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…loading-limits-on-iOS
…loading-limits-on-iOS
HexaField
requested changes
Jun 13, 2025
| @@ -710,13 +810,22 @@ const getAllResourcesOfType = (type: ResourceType) => { | |||
| return result | |||
| } | |||
|
|
|||
| const assetDiscarded = () => { | |||
There was a problem hiding this comment.
is it necessary to have listeners? can't we just react to the discarded state in ResourceState for each resource?
There was a problem hiding this comment.
There's no reactive context in the texture loader to listen to those changes
There was a problem hiding this comment.
we can do const reactor = startReactor(() => { ... }) to reactivify a promise, we do it in a few places already
HexaField
requested changes
Jun 13, 2025
| @@ -710,13 +810,22 @@ const getAllResourcesOfType = (type: ResourceType) => { | |||
| return result | |||
| } | |||
|
|
|||
| const assetDiscarded = () => { | |||
There was a problem hiding this comment.
we can do const reactor = startReactor(() => { ... }) to reactivify a promise, we do it in a few places already
speigg
approved these changes
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds queries to Resource state around asset memory usage and budgets
Limit concurrent images being loaded
Wait for images to be discarded if over budget before loading
Subtasks Checklist
Breaking Changes
References
closes #insert number here
QA Steps