-
Notifications
You must be signed in to change notification settings - Fork 235
IPIP 0499: CID Profiles #499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for Git 8000 Hub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
src/ipips/ipip-0499.md
Outdated
3. Chunk size | ||
4. DAG width | ||
5. DAG layout | ||
6. Required |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there's a word missing here 😅
lets make the fanout match the max links from files and rename profile to `-wide` this will make it easier to discuss in ipfs/specs#499
Co-authored-by: Bumblefudge <bumblefudge@learningproof.xyz>
Import.* config params for controlling DAG width were added in: ipfs/kubo#10774
Thank you for kicking this off, and filling initial state. I've incorporated specific "dag width" settings for Next:
|
|
||
#### Empty directories | ||
|
||
Decision if empty directories should be included is left out of scope. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lidel I think we should include this, because the goal of this spec is to make UnixFS encoding deterministic when using the profile, and this stands in the way of this, potentially rendering this whole effort futile if not included.
I think the profile should dictate whether empty directories are included. This should also be configurable such that you can adjust to your own needs.
On the same note, we should probably also add mention of hidden files which are also excluded by Storacha, Kubo, and Helia by default.
| `HAMTDirectory` threshold | 256KiB (est) | 256KiB (est:links[name+cid]) | 1000 **links** | 256KiB | **1MiB** | not specified | | ||
| DAG layout | balanced | balanced | balanced | balanced | balanced | not specified | | ||
| Leaves | raw | raw | raw | raw | raw | not specified | | ||
| Empty directories | allowed | allowed | disallowed | allowed | allowed | not specified | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's about the default behaviour rather than whether empty dirs are allowed.
No description provided.