8000 oc_reset_v1: allow to set close_all_tls_connections_immediately by jkralik · Pull Request #342 · iotivity/iotivity-lite · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

oc_reset_v1: allow to set close_all_tls_connections_immediately #342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 24, 2022
Merged

oc_reset_v1: allow to set close_all_tls_connections_immediately #342

merged 1 commit into from
Nov 24, 2022

Conversation

jkralik
Copy link
Member
@jkralik jkralik commented Nov 22, 2022

No description provided.

@ocf-conformance-test-tool
Copy link

🎉 Thank you for your code contribution! To guarantee the change/addition is conformant to the OCF Specification, we would like to ask you to execute OCF Conformance Testing of your change ☝️ when your work is ready to be reviewed.

ℹ️ To verify your latest change (25002f1), label this PR with OCF Conformance Testing.

⚠️ Label is removed with every code change.

@jkralik jkralik force-pushed the jkralik/feature/oc_reset_v1 branch 2 times, most recently from bb9efaa to 8bbeedc Compare November 22, 2022 12:26
@jkralik
Copy link
Member Author
jkralik commented Nov 22, 2022

~format

@jkralik jkralik marked this pull request as ready for review November 22, 2022 15:44
@jkralik jkralik force-pushed the jkralik/feature/oc_reset_v1 branch from df29a82 to 24c3a3a Compare November 22, 2022 15:46
@jkralik jkralik added the OCF Conformance Testing OCF Conformance Testing required label Nov 22, 2022
@ocf-conformance-test-tool ocf-conformance-test-tool bot removed the OCF Conformance Testing OCF Conformance Testing required label Nov 22, 2022
@Danielius1922
Copy link
Member

@jkralik what about a unit test for the new functions? You should be able to mock a connection using oc_tls_add_peer and then the reset should remove it.

@jkralik jkralik force-pushed the jkralik/feature/oc_reset_v1 branch 2 times, most recently from 78f9941 to 762c6c3 Compare November 23, 2022 08:27
Danielius1922
Danielius1922 reviewed Nov 23, 2022
View reviewed changes
@jkralik jkralik force-pushed the jkralik/feature/oc_reset_v1 branch 7 times, most recently from 474edd5 to 515b561 Compare November 23, 2022 13:10
@jkralik
Copy link
Member Author
jkralik commented Nov 23, 2022

~format

@jkralik jkralik force-pushed the jkralik/feature/oc_reset_v1 branch from dc863cc to eaed4c9 Compare November 23, 2022 14:18
@jkralik jkralik added the OCF Conformance Testing OCF Conformance Testing required label Nov 23, 2022
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

100.0% 100.0% Coverage
15.8% 15.8% Duplication

@Danielius1922 Danielius1922 merged commit fc7a58d into master Nov 24, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Nov 24, 2022
@jkralik jkralik deleted the jkralik/feature/oc_reset_v1 branch May 11, 2023 12:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Danielius1922 Danielius1922 Danielius1922 approved these changes

Assignees
No one assigned
Labels
OCF Conformance Testing OCF Conformance Testing required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jkralik @Danielius1922
0