api/cloud: include short tokens in deregister query #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some older cloud implementations expect the deregister requests to have access token in the query otherwise they regard the request as invalid. To support such implementations we append the token to query if the overall size of the request header is shorter or equal to COAP_MAX_HEADER_SIZE.
jkralik
reviewed
Aug 13, 2021
api/cloud/oc_cloud_apis.c
Outdated
| if (oc_string(ctx->store.ci_server) && conv_cloud_endpoint(ctx) == 0 && | ||
| cloud_access_deregister(ctx->cloud_ep, | ||
| oc_string(ctx->store.uid), | ||
| 0, | ||
| access_token, | ||
| /*device*/0, |
There was a problem hiding this comment.
why there is 0 instead of the device?
There was a problem hiding this comment.
Not really sure, but looking in my original commit ( c91cba1 ) it seems that the value for device has been always zero.
There was a problem hiding this comment.
could you change it to the device?
There was a problem hiding this comment.
Which value shoud I use though, ctx->store.device?
jkralik
reviewed
Aug 13, 2021
jkralik
reviewed
Aug 13, 2021
jkralik
reviewed
Aug 18, 2021
WAvdBeek
approved these changes
Aug 19, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some older cloud implementations expect the deregister
requests to have access token in the query otherwise
they regard the request as invalid. To support such
implementations we append the token to query if
the overall size of the request header is shorter
or equal to COAP_MAX_HEADER_SIZE.