Add missing .o files to libiotivity-lite-jni.so #635
Conversation
|
🎉 Thank you for your code contribution! To guarantee the change/addition is conformant to the OCF Specification, we would like to ask you to execute OCF Conformance Testing of your change ☝️ when your work is ready to be reviewed. ℹ️ To verify your latest change (27fe5d8), label this PR with |
WalkthroughThe changes incorporate path updates, compilation rule refinements, and new security settings in various Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- port/android/Makefile (2 hunks)
- swig/Makefile (3 hunks)
Additional comments not posted (6)
swig/Makefile (3)
134-134: Good addition to LDFLAG to ensure all symbols are defined.Including
-Wl,--no-undefinedhelps catch undefined symbols during the linking stage, improving build robustness.Also applies to: 141-141
150-150: Introduction of PORT_COMMON_OBJ_DIR enhances modularity.Centralizing the object files from the
port/commondirectories into a single variable improves maintainability and modularity.
181-181: Update to build_jni_so rule ensures inclusion of common object files.Including
$(PORT_COMMON_OBJ_DIR)*.oin the list of object files ensures that the common object files are correctly linked, completing the build process.port/android/Makefile (3)
199-199: Update to OBJ_PORT_COMMON path improves consistency.Using
${OBJDIR}/port/instead ofobj/port/aligns with the${OBJDIR}variable, enhancing consistency and flexibility in the build process.
329-329: Update to compilation rules for../../port/common/source files improves organization.Incorporating
${OBJDIR}into the target paths ensures that the compiled object files are placed in the correct directory structure, enhancing organization and maintainability.
333-333: Update to compilation rules for../../port/common/posix/source files improves organization.Incorporating
${OBJDIR}into the target paths ensures that the compiled object files are placed in the correct directory structure, enhancing organization and maintainability.
27fe5d8 to
4d4a1de
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- port/android/Makefile (2 hunks)
- swig/Makefile (3 hunks)
Files skipped from review as they are similar to previous changes (2)
- port/android/Makefile
- swig/Makefile
4d4a1de to
bbd3148
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
Outside diff range and nitpick comments (1)
swig/swig_interfaces/oc_api.i (1)
Line range hint
555-564:
Add a comment explaining the conditional compilation.The function
jni_reset_deviceconditionally callsoc_reset_devicebased onOC_SECURITY. Adding a comment to explain this would improve code readability.#ifdef OC_SECURITY // If security is enabled, call oc_reset_device with the device parameter. oc_reset_device(device); #else // If security is not enabled, the device parameter is unused. (void)device; #endif /* OC_SECURITY */
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (9)
- port/android/Makefile (2 hunks)
- port/android/ipadapter.c (2 hunks)
- swig/Makefile (5 hunks)
- swig/swig_interfaces/iotivity.swg (1 hunks)
- swig/swig_interfaces/oc_api.i (3 hunks)
- swig/swig_interfaces/oc_core_res.i (1 hunks)
- swig/swig_interfaces/oc_cred.i (4 hunks)
- swig/swig_interfaces/oc_obt.i (2 hunks)
- swig/swig_interfaces/oc_pki.i (1 hunks)
Files skipped from review due to trivial changes (2)
- swig/swig_interfaces/oc_cred.i
- swig/swig_interfaces/oc_pki.i
Files skipped from review as they are similar to previous changes (1)
- port/android/Makefile
Additional comments not posted (10)
swig/swig_interfaces/oc_core_res.i (1)
54-68: LGTM!The introduction of the
jni_core_is_SVRfunction with conditional logic based onOC_SECURITYis well-implemented. The renaming and debug statements are appropriate.swig/Makefile (4)
69-71: LGTM!The introduction of
SECUREandPKIsettings along with the security check to ensure PKI is not enabled without security is appropriate and necessary for maintaining secure builds.Also applies to: 94-96
140-140: LGTM!The addition of
-Wl,--no-undefinedand-llogto the linker flags for Linux and Android builds enhances the build process by ensuring all symbols are defined and adding logging support for Android.Also applies to: 147-147
156-156: LGTM!The introduction of
PORT_COMMON_OBJ_DIRenhances the organization and modularity of the build process.
187-187: LGTM!The update to the
build_jni_sorule to include the common object directory ensures that all necessary object files are included in the shared library build process.swig/swig_interfaces/iotivity.swg (1)
69-69: LGTM!The correction to the typemap declaration for
oc_cloud_status_tensures proper input casting.swig/swig_interfaces/oc_obt.i (1)
83-84: LGTM!Ignoring functions and types that are not yet implemented and adding TODO comments for future implementation help in maintaining the codebase and planning future development.
Also applies to: 117-118
port/android/ipadapter.c (2)
67-70: Ensure__ANDROID_API__is defined.The inclusion of
<android/api-level.h>and the check for__ANDROID_API__ensures that the Android API level is defined. If not, it raises a preprocessor error.
71-79: Conditional inclusion of headers based on Android API level.The code correctly includes the appropriate headers and defines macros for
getifaddrsandfreeifaddrsbased on the Android API level.swig/swig_interfaces/oc_api.i (1)
1013-1014: LGTM!Ignoring the function
oc_reset_v1is acceptable.
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- .github/workflows/android.yml (1 hunks)
Additional comments not posted (1)
.github/workflows/android.yml (1)
46-47: Verify the new configuration disabling security and PKI.Ensure that the configuration
SECURE=0 PKI=0is intended and verify its impact on the build and runtime behavior.
|
No description provided.