8000 Update query public API by Danielius1922 · Pull Request #533 · iotivity/iotivity-lite · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update query public API #533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 22, 2023
Merged

Update query public API #533

merged 2 commits into from
Sep 22, 2023

Conversation

Danielius1922
Copy link
Member

Extend the function signature to include the include the length of the key. If the length of the key is known then a call to strlen can be avoided.

Added:

  • oc_iterate_query_get_values_v1
  • oc_get_query_value_v1
  • oc_query_value_exists_v1
  • oc_ri_get_query_value_v1
  • oc_ri_query_exists_v1

Deprecated:

  • oc_iterate_query_get_values
  • oc_get_query_value
  • oc_query_value_exists
  • oc_ri_get_query_value
  • oc_ri_query_exists

Danielius1922
Danielius1922 commented Sep 18, 2023
View reviewed changes
@ocf-conformance-test-tool
Copy link

🎉 Thank you for your code contribution! To guarantee the change/addition is conformant to the OCF Specification, we would like to ask you to execute OCF Conformance Testing of your change ☝️ when your work is ready to be reviewed.

ℹ️ To verify your latest change (4808c17), label this PR with OCF Conformance Testing.

⚠️ Label is removed with every code change.

@Danielius1922 Danielius1922 force-pushed the adam/feature/update-query-api branch from 4808c17 to 165373b Compare September 18, 2023 12:37
@Danielius1922 Danielius1922 marked this pull request as ready for review September 18, 2023 12:42
@Danielius1922 Danielius1922 force-pushed the adam/feature/update-query-api branch 3 times, most recently from 259968b to c5a4793 Compare September 19, 2023 16:34
jkralik
jkralik reviewed Sep 20, 2023
View reviewed changes
jkralik
jkralik reviewed Sep 20, 2023
View reviewed changes
jkralik
jkralik reviewed Sep 20, 2023
View reviewed changes
@Danielius1922
Update query public API
257838a 
Extend the function signature to include the include the length
of the key. If the length of the key is known then a call to
strlen can be avoided.

Added:
  - oc_iterate_query_get_values_v1
  - oc_get_query_value_v1
  - oc_query_value_exists_v1
  - oc_ri_get_query_value_v1
  - oc_ri_query_exists_v1

Deprecated:
  - oc_iterate_query_get_values
  - oc_get_query_value
  - oc_query_value_exists
  - oc_ri_get_query_value
  - oc_ri_query_exists
@Danielius1922
fixup! Update query public API
ea0eca6
@Danielius1922 Danielius1922 force-pushed the adam/feature/update-query-api branch from c5a4793 to ea0eca6 Compare September 20, 2023 13:06
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 7 Code Smells

77.9% 77.9% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@Danielius1922 Danielius1922 added the OCF Conformance Testing OCF Conformance Testing required label Sep 20, 2023
@Danielius1922 Danielius1922 merged commit 92a1811 into master Sep 22, 2023
@Danielius1922 Danielius1922 deleted the adam/feature/update-query-api branch September 22, 2023 13:33
@github-actions github-actions bot locked and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jkralik jkralik jkralik approved these changes

Assignees
No one assigned
Labels
OCF Conformance Testing OCF Conformance Testing required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Danielius1922 @jkralik
0