feat: configure subscribers_per_topic for momento pubsub workflow #363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brayniac
approved these changes
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
A momento client can only support a maximum of 100 subscriptions due to the server side GRPC restriction on concurrent streams per connection. The current implementation assumes that all subscribers subscribe to all topics.
We are hence unable to test workflows like 10 topics with 100 subscribers each and we also run into issues if the number of subscriptions created is more than 100 * number of clients.
Solution
Add a configuration option for subscribers per topic and add runtime checks to fail if the configuration tries to create more subscriptions than what the clients can support.