8000 Feature/animatable layout property by gmlwhdtjd · Pull Request #187 · ioskrew/SwiftLayout · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Feature/animatable layout property #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 28, 2022
Merged

Feature/animatable layout property #187

merged 2 commits into from
Mar 28, 2022

Conversation

gmlwhdtjd
Copy link
Contributor
@gmlwhdtjd gmlwhdtjd commented Mar 28, 2022 •
edited
Loading

from

var flag = true {
  didSet {
    UIView.animate(withDuration: 1.0) {
      self.sl.updateLayout(forceLayout: true)
    }
  }
}

to

@AnimatableLayoutProperty(duration: 1.0) var flag = true

@gmlwhdtjd gmlwhdtjd self-assigned this Mar 28, 2022
@gmlwhdtjd gmlwhdtjd added the enhancement New feature or request label Mar 28, 2022
@gmlwhdtjd gmlwhdtjd requested a review from oozoofrog March 28, 2022 07:21
oozoofrog
oozoofrog approved these changes Mar 28, 2022
View reviewed changes
Copy link
Collaborator
@oozoofrog oozoofrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i fall in love to this feature.

@gmlwhdtjd gmlwhdtjd merged commit 3fc197d into develop Mar 28, 2022
@gmlwhdtjd gmlwhdtjd deleted the feature/AnimatableLayoutProperty branch March 28, 2022 11:39
@oozoofrog oozoofrog mentioned this pull request Mar 31, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oozoofrog oozoofrog oozoofrog approved these changes

Assignees

@gmlwhdtjd gmlwhdtjd

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gmlwhdtjd @oozoofrog
0