8000 [SYCL] Use same source for libsycl-crt by jinge90 · Pull Request #3019 · intel/llvm · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[SYCL] Use same source for libsycl-crt #3019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 21, 2021
Merged

[SYCL] Use same source for libsycl-crt #3019

merged 3 commits into from
Jan 21, 2021

Conversation

jinge90
Copy link
Contributor
@jinge90 jinge90 commented Jan 12, 2021

Signed-off-by: gejin ge.jin@intel.com

@jinge90 jinge90 requested a review from vzakhari as a code owner January 12, 2021 05:56
@jinge90
Use same source for libsycl-crt
050683f 
Signed-off-by: gejin <ge.jin@intel.com>
@jinge90
Fix typo
eefef1e 
Signed-off-by: gejin <ge.jin@intel.com>
@jinge90
Fix typo
2d03bdf 
Signed-off-by: gejin <ge.jin@intel.com>
@jinge90
Copy link
Contributor Author
jinge90 commented Jan 12, 2021

Currently, the implementation of assert support for Linux and Windows are in 2 files glibc_wrapper.cpp and msvc_wrapper.cpp. We can merge them into one source and use macro "_WIN32" to separate Windows and Linux specific code.
We plan to add some more functions in libsycl-crt in the future and the implementation may be same for both Linux and Windows platform, keeping 2 different sources for Linux and Windows will lead to duplicate code then.
Thanks very much.

@jinge90 jinge90 changed the title [SYCL]Use same source for libsycl-crt [SYCL] Use same source for libsycl-crt Jan 13, 2021
@jinge90
Copy link
Contributor Author
jinge90 commented Jan 18, 2021

Hi, @vzakhari
Could you help review this patch?
Thanks very much.

vzakhari
vzakhari approved these changes Jan 21, 2021
View reviewed changes
Copy link
Contributor
@vzakhari vzakhari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bader bader merged commit 117641e into intel:sycl Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vzakhari vzakhari vzakhari approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jinge90 @vzakhari @bader
0