10000 [SYCL] [FPGA] Fix linking error with template parameter support for work_group_size attributes by smanna12 · Pull Request #2975 · intel/llvm · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[SYCL] [FPGA] Fix linking error with template parameter support for work_group_size attributes #2975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 31, 2020
Merged

[SYCL] [FPGA] Fix linking error with template parameter support for work_group_size attributes #2975

merged 1 commit into from
Dec 31, 2020

Conversation

smanna12
Copy link
Contributor
@smanna12 smanna12 commented Dec 31, 2020 •
edited
Loading

A linking error was introduced on PR #2906 where
template declaration and definition was added in different files.

This patch fixes the issue by moving the template definition for
addIntelSYCLTripleArgFunctionAttr to Sema.h.

Signed-off-by: Soumi Manna soumi.manna@intel.com

@smanna12
[SYCL] [FPGA] Fix linking error with template parameter support for w…
0b12530 
…ork_group_size attributes

A linking error was introduced on PR intel#2906 where
template declaration and definition was added in different files.

This patch fixes the issue by moving the template definition for
addIntelSYCLTripleArgFunctionAttr to Sema.h.

Signed-off-by: Soumi Manna <soumi.manna@intel.com>
@smanna12 smanna12 changed the title [SYCL] [FPGA] Fix linking error with template parameter support for w… [SYCL] [FPGA] Fix linking error with template parameter support for work_group_size Attribute Dec 31, 2020
@smanna12 smanna12 changed the title [SYCL] [FPGA] Fix linking error with template parameter support for work_group_size Attribute [SYCL] [FPGA] Fix linking error with template parameter support for work_group_size attribute Dec 31, 2020
@smanna12 smanna12 changed the title [SYCL] [FPGA] Fix linking error with template parameter support for work_group_size attribute [SYCL] [FPGA] Fix linking error with template parameter support for work_group_size attributes Dec 31, 2020
@smanna12 smanna12 marked this pull request as ready for review December 31, 2020 04:56
@vladimirlaz vladimirlaz merged commit 289230c into intel:sycl Dec 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fznamznon Fznamznon Fznamznon approved these changes

@elizabethandrews elizabethandrews Awaiting requested review from elizabethandrews

@premanandrao premanandrao Awaiting requested review from premanandrao

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smanna12 @Fznamznon @vladimirlaz
0