[SYCL] Fixed bug regarding device caching #2566
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created a new function, getOrCreateDevice, so that cached devices could be shared across both piDevicesGet and piextDeviceCreateWithNativeHandle. This new function will check/fill and return cached devices.
Created a new function, populateDeviceCacheIfNeeded, so that cached devices could be shared across both piDevicesGet and piextDeviceCreateWithNativeHandle. This new function will check/fill and return cached devices. Renamed getOrCreatePlatforms to getPlatformCache, and refactored the function so that it limits level zero driver calls and removes redundant code.
|
Mentioning @gmlueck for comments/code-review. |
gmlueck
reviewed
Oct 1, 2020
gmlueck
reviewed
Oct 1, 2020
gmlueck
reviewed
Oct 1, 2020
gmlueck
reviewed
Oct 1, 2020
gmlueck
reviewed
Oct 1, 2020
gmlueck
reviewed
Oct 1, 2020
gmlueck
reviewed
Oct 1, 2020
gmlueck
reviewed
Oct 1, 2020
gmlueck
reviewed
Oct 1, 2020
|
I think it would also be good to add errors checks to the calls to |
Currently, error checking is already occurring through the plugin::call interface. PI function calls (in this case 'piextDeviceCreateWithNativeHandle()' and 'piextPlatformCreateWithNativeHandle()') are passed into plugin::call as an argument and invoked from here. The result of the PI call is recorded and is passed into a function called checkPiResult() which will throw an exception if the result is not a PI_SUCCESS. |
gmlueck
reviewed
Oct 6, 2020
gmlueck
reviewed
Oct 6, 2020
Created a new function, populateDeviceCacheIfNeeded, so that cached devices could be shared across both piDevicesGet and piextDeviceCreateWithNativeHandle. This new function will check/fill and return cached devices. Renamed getOrCreatePlatforms to getPlatformCache, and refactored the function so that it limits level zero driver calls and removes redundant code. Also, added an E2E test for these changes.
gmlueck
reviewed
Oct 8, 2020
gmlueck
reviewed
Oct 8, 2020
gmlueck
reviewed
Oct 8, 2020
gmlueck
reviewed
Oct 8, 2020
gmlueck
reviewed
Oct 8, 2020
Created a new function, populateDeviceCacheIfNeeded, so that cached devices could be shared across both piDevicesGet and piextDeviceCreateWithNativeHandle. This new function will check/fill and return cached devices. Renamed getOrCreatePlatforms to getPlatformCache, and refactored the function so that it limits level zero driver calls and removes redundant code. Called getOrMakePlatformImpl() from make_platform() so that the PlatformImpl cache is accessible to platforms that are created using a native handle. Called getOrMakeDeviceImpl() from make_device() so that the DeviceImpl cache is accessible to devices that are created using a native handle. Also, added an E2E test for these changes.
gmlueck
reviewed
Oct 9, 2020
gmlueck
reviewed
Oct 9, 2020
gmlueck
reviewed
Oct 9, 2020
Made make_platform() and make_device() friends of the platform and device class, respectively.
|
@smaslov-intel @romanovvlad Do you have any comments on these changes? |
romanovvlad
requested changes
Oct 12, 2020
Added check for Level Zero Drivers/Devices to cache_test.cpp Removed line changes from platform and device constructors.
Removed direct reference to level_zero namespace from generic SYCL headers (device and platform headers).
Created a new function, populateDeviceCacheIfNeeded, so that cached devices could be shared across both piDevicesGet and piextDeviceCreateWithNativeHandle. This new function will check/fill and return cached devices. Removed the function getOrCreatePlatforms. Refactored PiPlatformsGet to limit the number Level Zero driver calls. Called PiPlatformsGet from piextPlatformCreateWithNativeHandle so that the latter has access to the platform cache maintained in the former. Called getOrMakePlatformImpl from make_platform so that the PlatformImpl cache is accessible to platforms that are created using a native handle. Called getOrMakeDeviceImpl from make_device so that the DeviceImpl cache is accessible to devices that are created using a native handle. Also, added an E2E test for these changes.
gmlueck
reviewed
Oct 14, 2020
gmlueck
reviewed
Oct 14, 2020
Removed unnecessary lambda function from PiPlatformsGet.
Fixed typo in comments. Co-authored-by: smaslov-intel <48694368+smaslov-intel@users.noreply.github.com>
C097
smaslov-intel
approved these changes
Oct 15, 2020
kbenzie
pushed a commit
to kbenzie/intel-llvm
that referenced
this pull request
Feb 17, 2025
ShadowMemory should increment/decrement device handle
Chenyang-L
pushed a commit
that referenced
this pull request
Feb 18, 2025
ShadowMemory should increment/decrement device handle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a new function, populateDeviceCacheIfNeeded, so that cached devices could be
shared across both piDevicesGet and piextDeviceCreateWithNativeHandle. This
new function will check/fill and return cached devices.
Renamed getOrCreatePlatforms to getPlatformCache, and refactored the function so
that it limits level zero driver calls and removes redundant code.
Called getOrMakePlatformImpl() from make_platform() so that the PlatformImpl
cache is accessible to platforms that are created using a native handle.
Called getOrMakeDeviceImpl() from make_device() so that the DeviceImpl cache is
accessible to devices that are created using a native handle.
Also, added an E2E test for these changes.