8000 [UR][CTS] Skip failing command-buffer OpenCL CTS tests by EwanC · Pull Request #19138 · intel/llvm · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[UR][CTS] Skip failing command-buffer OpenCL CTS tests #19138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 26, 2025
Merged

[UR][CTS] Skip failing command-buffer OpenCL CTS tests #19138

merged 1 commit into from
Jun 26, 2025

Conversation

EwanC
Copy link
Contributor
@EwanC EwanC commented Jun 25, 2025

buffer read/write CTS tests aren't supported for the OpenCL adapter, because there is a gap in cl_khr_command_buffer that blocks implementing the required UR entry-points

KhronosGroup/OpenCL-Docs#1281 is the cl_khr_command_buffer issue progressing this.

@EwanC EwanC marked this pull request as ready for review June 25, 2025 09:59
@EwanC EwanC requested a review from a team as a code owner June 25, 2025 09:59
@EwanC EwanC requested a review from reble June 25, 2025 09:59
@EwanC EwanC force-pushed the ewan/skip_read_write_opencl_UR_CTS branch 3 times, most recently from dbf97be to 3b5c77b Compare June 25, 2025 12:25
@EwanC EwanC mentioned this pull request Jun 25, 2025
Open
@EwanC EwanC force-pushed the ewan/skip_read_write_opencl_UR_CTS branch from 3b5c77b to 3e4625a Compare June 25, 2025 12:49
@EwanC EwanC changed the title [UR][CTS] Skip command-buffer OpenCL CTS tests [UR][CTS] Skip failing command-buffer OpenCL CTS tests Jun 25, 2025
@EwanC
Copy link
Contributor Author
EwanC commented Jun 25, 2025 •
edited
Loading

@intel/llvm-gatekeepers I think we should merge this, it's fixes precommit CI fails in unrelated PRs.

The red CI configs are due to a separate subprocess.CalledProcessError: Command '/__w/llvm/llvm/build/bin/urinfo' died with <Signals.SIGSEGV: 11>. issue, and I restarted the Jenkins precommit job internally and it passed, although that doesn't get reflected here.

Edit: I've rebased to rerun CI and see if these unrelated issues are gone

@igchor igchor mentioned this pull request Jun 25, 2025
Merged
@EwanC
[UR][CTS] Skip command-buffer OpenCL CTS tests
b3e018e 
buffer read/write CTS tests aren't supported for the
OpenCL adapter, because there is a gap in cl_khr_command_buffer
that blocks implementing the required UR entry-points

KhronosGroup/OpenCL-Docs#1281 is the
cl_khr_command_buffer issue progressing this.
@EwanC EwanC force-pushed the ewan/skip_read_write_opencl_UR_CTS branch from 3e4625a to b3e018e Compare June 26, 2025 07:16
@EwanC
Copy link
Contributor Author
EwanC commented Jun 26, 2025

@intel/llvm-gatekeepers This is ready to merge now with green CI

@sommerlukas sommerlukas merged commit b0a40e2 into intel:sycl Jun 26, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bensuo Bensuo Bensuo approved these changes

@reble reble Awaiting requested review from reble reble is a code owner automatically assigned from intel/sycl-graphs-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EwanC @Bensuo @sommerlukas
0