[SYCL-JIT][NFCI] Enable few extra warnings #19118
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Those extra flags are required per our internal guidelines (the full list you can find in `llvm/cmake/modules/AddSecurityFlags.cmake`. Even though we have this shared cmake module that applies those flags, I don't think that we will be able to use it for every flag, because baseline LLVM that we use isn't warning-free. Therefore, those flags were directly applied to `sycl-jit`.
sommerlukas
approved these changes
Jun 24, 2025
| @@ -22,7 +22,7 @@ template <typename T> class DynArray { | |||
| explicit DynArray(size_t Size) { init(Size); } | |||
|
|
|||
| template <typename InputIt> DynArray(InputIt Begin, InputIt End) { | |||
| init(End - Begin); | |||
| init(static_cast<size_t>(End - Begin)); | |||
There was a problem hiding this comment.
Would std::distance work here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those extra flags are required per our internal guidelines (the full list you can find in
llvm/cmake/modules/AddSecurityFlags.cmake.Even though we have this shared cmake module that applies those flags, I don't think that we will be able to use it for every flag, because baseline LLVM that we use isn't warning-free. Therefore, those flags were directly applied to
sycl-jit.