8000 [UR][Offload] Add OL_RETURN_ON_ERR macro by callumfare · Pull Request #19170 · intel/llvm · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[UR][Offload] Add OL_RETURN_ON_ERR macro #19170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2025

Conversation

callumfare
Copy link
Contributor

Add a macro for calling Offload API functions and returning a UR error on failure. Some Offload calls were unchecked before.

@callumfare callumfare requested a review from a team as a code owner June 26, 2025 10:43
Copy link
Contributor
@RossBrunton RossBrunton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested it locally, and it doesn't look like there's any new failures on AMD from this.

@callumfare
Copy link
Contributor Author

@intel/llvm-gatekeepers Please merge

@sommerlukas sommerlukas merged commit 858fd15 into intel:sycl Jun 27, 2025
44 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0