8000 [SYCL] [UR] [Graphs] Added missing UR_CALLs by konradkusiak97 · Pull Request #19143 · intel/llvm · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[SYCL] [UR] [Graphs] Added missing UR_CALLs #19143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: sycl
Choose a base branch
from
Open

[SYCL] [UR] [Graphs] Added missing UR_CALLs #19143

wants to merge 3 commits into from

Conversation

konradkusiak97
Copy link
Contributor

Small fixes flagged by static analyzer:

  • Added missing UR_CALL and UR_CALL_NOCHECK to ur::level_zero function calls in Command Buffer,
  • Removed one redundant copy of shared_ptr

@konradkusiak97 konradkusiak97 requested a review from a team as a code owner June 25, 2025 15:30
@konradkusiak97 konradkusiak97 requested a review from Bensuo June 25, 2025 15:30
pbalcer
pbalcer reviewed Jun 26, 2025
View reviewed changes
Copy link
Contributor
@pbalcer pbalcer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's one more missing UR_CALL found by coverity: https://github.com/intel/llvm/blob/sycl/unified-runtime/source/adapters/level_zero/command_buffer.cpp#L1515-L1516

Can you fix that as well?

@konradkusiak97
Copy link
Contributor Author
konradkusiak97 commented Jun 26, 2025 •
edited
Loading

There's one more missing UR_CALL found by coverity: https://github.com/intel/llvm/blob/sycl/unified-runtime/source/adapters/level_zero/command_buffer.cpp#L1515-L1516

Can you fix that as well?

Aye, thanks for pointing out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pbalcer pbalcer pbalcer approved these changes

@Bensuo Bensuo Bensuo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@konradkusiak97 @pbalcer @Bensuo
0