[Benchmarks] Add chart annotations #19023
Conversation
7b0d277 to
9dd752e
Compare
9dd752e to
556f734
Compare
|
Can you show a screenshot? |
Sure, here is an example with three annotations clicked, hence their labels are visible (active). The default view includes no labels being displayed. |
| name: "Compute Benchmarks", | ||
| url: "https://github.com/intel/compute-benchmarks.git", | ||
| color: { | ||
| border: 'rgba(220, 53, 69, 0.8)', |
There was a problem hiding this comment.
I know it's a minor thing, but maybe we should pick colors that aren't similar to what we use for data series? someone might misinterpret the annotation as relating to just one series.
(i'm not sure it's going to be possible).
There was a problem hiding this comment.
The most reliable way (same view of annotation lines across all charts) of solving this issue that came to my mind is to always use a gray scale for annotations with varying dash length. It would look like this, let me know what you think:
There was a problem hiding this comment.
ok, I think I preferred the predefined colors, but pick a pastel palette so that it's differentiated from the series colors.
There was a problem hiding this comment.
the colors has changed, an example:
| name: "Compute Benchmarks", | ||
| url: "https://github.com/intel/compute-benchmarks.git", |
There was a problem hiding this comment.
aren't these stored in group metadata? we should ideally create this list automatically.
556f734 to
0364317
Compare
0364317 to
5b244de
Compare
with information on each version change of important dependecies, like Compute Runtime and benchmarks repos
|
@intel/llvm-gatekeepers, please merge |
with information on each version change of important dependecies, like Compute Runtime and benchmarks repos.
To see a label with a new version of Compute Runtime or a benchmark, click the annotation.