8000 [SYCL] [Graph] Refactor graph headers by konradkusiak97 · Pull Request #19045 · intel/llvm · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[SYCL] [Graph] Refactor graph headers #19045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 23 commits into from
Jun 25, 2025
Merged

[SYCL] [Graph] Refactor graph headers #19045

merged 23 commits into from
Jun 25, 2025

Conversation

konradkusiak97
Copy link
Contributor
@konradkusiak97 konradkusiak97 commented Jun 18, 2025 •
edited
Loading

Creates new file structure of Graph code. In the public headers it'll now be:

├── graph
│   ├── command_graph.hpp
│   ├── executable_graph.hpp
│   ├── dynamic.hpp
│   ├── node.hpp
│   └── modifiable_graph.hpp
├── graph.hpp

where graph.hpp just contains the includes of the remaining headers in graph/.

Inside the impl section, source/detail it'll be:

├── graph
│   ├── dynamic_impl.cpp
│   ├── dynamic_impl.hpp
│   ├── graph_impl.cpp
│   ├── graph_impl.hpp
│   ├── memory_pool.cpp
│   ├── memory_pool.hpp
│   ├── node_impl.cpp
│   └── node_impl.hpp

The includes in all files have been updated such that forward declarations are favoured wherever possible.

@konradkusiak97 konradkusiak97 force-pushed the konrad/RefactorGraphHeaders branch 3 times, most recently from 559ada9 to 1eca2fc Compare June 19, 2025 20:12
@konradkusiak97 konradkusiak97 marked this pull request as ready for review June 19, 2025 20:53
@konradkusiak97 konradkusiak97 requested review from a team as code owners June 19, 2025 20:53
EwanC
EwanC reviewed Jun 20, 2025
View reviewed changes
@konradkusiak97 konradkusiak97 requested a review from a team as a code owner June 23, 2025 08:08
@konradkusiak97 konradkusiak97 force-pushed the konrad/RefactorGraphHeaders branch from 736dd22 to 2439ca4 Compare June 23, 2025 08:37
@konradkusiak97 konradkusiak97 force-pushed the konrad/RefactorGraphHeaders branch from 2439ca4 to 438bd63 Compare June 23, 2025 08:48
uditagarwal97
uditagarwal97 approved these changes Jun 23, 2025
View reviewed changes
Copy link
Contributor
@uditagarwal97 uditagarwal97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devops changes LGTM.

@uditagarwal97 uditagarwal97 requested a review from a team June 23, 2025 14:55
@konradkusiak97 konradkusiak97 force-pushed the konrad/RefactorGraphHeaders branch from e0f384b to 3f7a911 Compare June 23, 2025 17:01
fabiomestre
fabiomestre reviewed Jun 24, 2025
View reviewed changes
@konradkusiak97
Splitted the code from graph.hpp into seperate files
23efa83
@konradkusiak97
Merged definition and declaration of print_graph
a13fe83
@konradkusiak97
Copied graph impl files into new files in graph/
d50f522
@konradkusiak97
Splitted the code from graph_impl.hpp(.cpp) into seperate files
9c30de8
@konradkusiak97
Renamed files
e158852
@konradkusiak97
Removed files
726de46
@konradkusiak97
Fixes to compile
c57a810
@konradkusiak97
Further splitted command_graph into modifiable and executable
c9d6bb8
@konradkusiak97
Dumb windows
55e7049
@konradkusiak97
Copied to new names to preserve history
09470c9
@konradkusiak97
Removed graph_* files
bb592bc
@konradkusiak97
Removed unnecesary includes
2bec6bb
@konradkusiak97
Modified CODEOWNERS for new graph files
d1d4905
@konradkusiak97
Added proper include to graph_properties after moving the helper func…
ccf04bf 
…tion
@konradkusiak97
Fixed includes and hashes
58ce40e
@konradkusiak97
Fixed dependencies file
498bf9e
@konradkusiak97
Changed names of public files in graph
124b117
@konradkusiak97
Changed naming in includes and deleted unnecesary files
e36f1d9
@konradkusiak97
Removed white spaces and fixed formating
88ec242
@konradkusiak97
Moved graph_state to common.hpp
16cedbe
@konradkusiak97
Patched changes from c73c9d0 commit
dc48d70
@konradkusiak97 konradkusiak97 force-pushed the konrad/RefactorGraphHeaders branch from ee094b8 to dc48d70 Compare June 25, 2025 14:00
@konradkusiak97
Copy link
Contributor Author

@intel/llvm-gatekeepers this is ready to merge. Thanks

@aelovikov-intel aelovikov-intel merged commit adf3592 into intel:sycl Jun 25, 2025
37 of 38 checks passed
@konradkusiak97 konradkusiak97 mentioned this pull request Jun 25, 2025
Merged
@konradkusiak97
Copy link
Contributor Author

FYI this broke post commit windows CI but here is the fix: #19149

sarnex pushed a commit that referenced this pull request Jun 25, 2025
@konradkusiak97
[SYCL] [Graph] Remove unnecesary SYCL_EXPORT (#19149)
3f3f9d5 
Fixes post-commit windows CI failure introduced by #19045
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EwanC EwanC EwanC left review comments

@Bensuo Bensuo Bensuo left review comments

@cperkinsintel cperkinsintel cperkinsintel approved these changes

@fabiomestre fabiomestre fabiomestre approved these changes

@uditagarwal97 uditagarwal97 uditagarwal97 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@konradkusiak97 @EwanC @cperkinsintel @fabiomestre @Bensuo @uditagarwal97 @aelovikov-intel
0