8000 [SYCL][NFC] Refactor common helpers by AlexeySachkov · Pull Request #19044 · intel/llvm · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[SYCL][NFC] Refactor common helpers #19044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: sycl
Choose a base branch
from
Open

[SYCL][NFC] Refactor common helpers #19044

wants to merge 2 commits into from

Conversation

AlexeySachkov
Copy link
Contributor
  • Dropped barely used __SYCL_ASSERT macro
  • Moved __SYCL_UR_ERROR_REPORT macro and corresponding helper function to library
  • Moved helpers thare are used in a single header to that header to reduce their impact on other headers
  • Moved some helpers into the library

@AlexeySachkov
[SYCL][NFC] Refactor common helpers
e659b44 
- Dropped barely used `__SYCL_ASSERT` macro
- Moved `__SYCL_UR_ERROR_REPORT` macro and corresponding helper function
  to library
- Moved helpers thare are used in a single header to that header to
  reduce their impact on other headers
@AlexeySachkov AlexeySachkov requested a review from a team as a code owner June 18, 2025 12:43
bader
bader reviewed Jun 18, 2025
View reviewed changes
aelovikov-intel
aelovikov-intel reviewed Jun 26, 2025
View reviewed changes
sycl/include/sycl/vector.hpp
// Helper function for creating an arbitrary sized array with the same value
// repeating.
template <typename T, size_t... Is>
static constexpr std::array<T, sizeof...(Is)>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#19183 instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bader bader bader left review comments

@aelovikov-intel aelovikov-intel aelovikov-intel left review comments

@cperkinsintel cperkinsintel cperkinsintel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AlexeySachkov @bader @cperkinsintel @aelovikov-intel
0