8000 [SYCL][NFC] Remove `sampled_image_accessor` and `unsampled_image_accessor` from required testing items outlined in the test plan for free function kernels extension by dyniols · Pull Request #18994 · intel/llvm · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[SYCL][NFC] Remove sampled_image_accessor and unsampled_image_accessor from required testing items outlined in the test plan for free function kernels extension #18994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dyniols
Copy link
Contributor
@dyniols dyniols commented Jun 16, 2025

This PR removes sampled_image_accessor and unsampled_image_accessor from required testing items outlined in the test plan for free function kernels extension. It's is done because sampled_image_accessor and unsampled_image_accessor are not supported by any device and they're only supported by host.

@dyniols dyniols changed the title Remove sampled_image_accessor and unsampled_image_accessor from the list of items to test for free function kernels extension Remove sampled_image_accessor and unsampled_image_accessor from required testing items outlined in the test plan for free function kernels extension Jun 16, 2025
@dyniols dyniols requested a review from steffenlarsen June 16, 2025 14:52
@dyniols dyniols marked this pull request as ready for review June 16, 2025 14:52
@dyniols dyniols requested a review from a team as a code owner June 16, 2025 14:52
@dyniols dyniols changed the title Remove sampled_image_accessor and unsampled_image_accessor from required testing items outlined in the test plan for free function kernels extension [SYCL] Remove sampled_image_accessor and unsampled_image_accessor from required testing items outlined in the test plan for free function kernels extension Jun 16, 2025
@dyniols dyniols changed the title [SYCL] Remove sampled_image_accessor and unsampled_image_accessor from required testing items outlined in the test plan for free function kernels extension [SYCL][NFC] Remove sampled_image_accessor and unsampled_image_accessor from required testing items outlined in the test plan for free function kernels extension Jun 16, 2025
@dyniols
Copy link
Contributor Author
dyniols commented Jun 16, 2025

@intel/llvm-gatekeepers Can we merge this PR ?

@steffenlarsen steffenlarsen merged commit 493ac99 into intel:sycl Jun 16, 2025
3 checks passed
martygrant pushed a commit that referenced this pull request Jun 23, 2025
…ssor` from test plan for free function kernels extension (#19086)

This PR removes `sampled_image_accessor` and unsampled_image_accessor
from planned test regarding structs that containing special types such
as `accessor` and `local_accessor`.
It's fix because it was not removed in previous PR:
#18994

---------

Co-authored-by: Steffen Larsen <steffen.larsen@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0