[UR][Benchmarks] Add oneDNN benchmarks #18883
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbalcer
reviewed
Jun 10, 2025
Comment on lines
101
to
162
|
|
||
| if not options.sycl == None: |
There was a problem hiding this comment.
will this ever work without sycl?
if not, I suggest just returning early, like here:
https://github.com/intel/llvm/blob/sycl/devops/scripts/benchmarks/benches/llamacpp.py#L32-L33
|
|
||
| def name(self): | ||
| return f"onednn-{self.bench_name}" | ||
|
|
There was a problem hiding this comment.
please implemented enabled. see example here.
PatKamin
reviewed
Jun 10, 2025
Signed-off-by: Mateusz P. Nowak <mateusz.p.nowak@intel.com>
PatKamin
reviewed
Jun 11, 2025
pbalcer
reviewed
Jun 12, 2025
Comment on lines
+184
to
+116
| if options.ur_adapter == "cuda" or options.ur_adapter == "hip": | ||
| return False |
There was a problem hiding this comment.
@omarahmed1111 fyi: we are going to merge this probably with cuda/hip disabled. You might want to test and remove this condition if it turns out everything is working.
pbalcer
reviewed
Jun 12, 2025
Signed-off-by: Mateusz P. Nowak <mateusz.p.nowak@intel.com>
Signed-off-by: Mateusz P. Nowak <mateusz.p.nowak@intel.com>
Signed-off-by: Mateusz P. Nowak <mateusz.p.nowak@intel.com>
Signed-off-by: Mateusz P. Nowak <mateusz.p.nowak@intel.com>
pbalcer
approved these changes
Jun 24, 2025
PatKamin
approved these changes
Jun 24, 2025
|
@intel/llvm-gatekeepers ready for merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A selection of OneDNN benchmarks added to the benchmark suite