8000 [NFCI][SYCL] Refactor reduction-handler interactions by aelovikov-intel · Pull Request #18794 · intel/llvm · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[NFCI][SYCL] Refactor reduction-handler interactions #18794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 6, 2025
Merged

[NFCI][SYCL] Refactor reduction-handler interactions #18794

merged 2 commits into from
Jun 6, 2025

Conversation

aelovikov-intel
Copy link
Contributor
@aelovikov-intel aelovikov-intel commented Jun 3, 2025 •
edited
Loading
  1. Move reduction::withAuxHandler -> HandlerAccess::postProcess, as that's what it's really about.
  2. Add comments describing what I see as issues with the previous/current implementation plus minor fixes of what I could address easily.
  3. Added HandlerAccess:preProcess instead of using addCounterInit introduced in
    [SYCL] Add nested calls detection to shortcut functions #13659. The original idea behind withAuxHandler and reduction implementations in general is to decouple them from SYCL RT internals as much as possible and addCounterInit was a step in the exact opposite direction.

@aelovikov-intel aelovikov-intel requested a review from a team as a code owner June 3, 2025 20:07
@aelovikov-intel aelovikov-intel marked this pull request as draft June 3, 2025 21:29
@aelovikov-intel aelovikov-intel changed the title [NFC][SYCL] Use reduction::withAuxhandler instead of addCounterInit [NFC][SYCL] Refactor reduction-handler interactions Jun 4, 2025
@aelovikov-intel aelovikov-intel force-pushed the remove-add-counter-init branch from 87729bb to b1463e2 Compare June 4, 2025 15:51
@aelovikov-intel aelovikov-intel marked this pull request as ready for review June 4, 2025 15:58
@aelovikov-intel aelovikov-intel marked this pull request as draft June 4, 2025 17:14
@aelovikov-intel aelovikov-intel force-pushed the remove-add-counter-init branch from b1463e2 to 452f2f2 Compare June 5, 2025 21:23
@aelovikov-intel aelovikov-intel force-pushed the remove-add-counter-init branch from 452f2f2 to 633eee4 Compare June 5, 2025 21:27
@aelovikov-intel aelovikov-intel marked this pull request as ready for review June 5, 2025 21:29
@aelovikov-intel
Copy link
Contributor Author
aelovikov-intel commented Jun 5, 2025 •
edited
Loading

@slawekptak , @igchor , @KseniyaTikhomirova , @steffenlarsen FYI if you're interested.

@aelovikov-intel aelovikov-intel changed the title [NFC][SYCL] Refactor reduction-handler interactions [NFCI][SYCL] Refactor reduction-handler interactions Jun 5, 2025
@aelovikov-intel aelovikov-intel force-pushed the remove-add-counter-init branch from 633eee4 to 76218b1 Compare June 6, 2025 14:28
sergey-semenov
sergey-semenov approved these changes Jun 6, 2025
View reviewed changes
@aelovikov-intel @sergey-semenov
Update sycl/include/sycl/handler.hpp
c3000fc 
Co-authored-by: Sergey Semenov <sergey.semenov@intel.com>
@aelovikov-intel aelovikov-intel merged commit 0211dd1 into intel:sycl Jun 6, 2025
27 of 28 checks passed
@aelovikov-intel aelovikov-intel deleted the remove-add-counter-init branch June 6, 2025 17:14
@aelovikov-intel aelovikov-intel mentioned this pull request Jun 6, 2025
Merged
aelovikov-intel added a commit to aelovikov-intel/llvm that referenced this pull request Jun 6, 2025
@aelovikov-intel
[NFCI][SYCL] Complete handler::MQueue->handler_impl move
fd4300f 
Initially started in intel#18830
Subsequent PRs before this final one:

intel#18794
intel#18834
intel#18748
aelovikov-intel added a commit that referenced this pull request Jun 9, 2025
@aelovikov-intel
[NFCI][SYCL] Complete handler::MQueue->handler_impl move (#18767)
9457ac2 
Initially started in #18830
Subsequent PRs before this final one:

#18794
#18834
#18748
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergey-semenov sergey-semenov sergey-semenov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aelovikov-intel @sergey-semenov
0