10000 [DeviceMSAN] Enable origin tracking by AllanZyne · Pull Request #18693 · intel/llvm · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[DeviceMSAN] Enable origin tracking #18693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 28 commits into from
Jun 24, 2025
Merged

[DeviceMSAN] Enable origin tracking #18693

merged 28 commits into from
Jun 24, 2025

Conversation

AllanZyne
Copy link
Contributor
@AllanZyne AllanZyne commented May 28, 2025 •
edited
Loading

Enable origin tracking for host/shared/device USM, which can provide the more debug information about the detected uninitialized memory.

@AllanZyne AllanZyne marked this pull request as ready for review June 17, 2025 01:47
@AllanZyne AllanZyne requested review from a team as code owners June 17, 2025 01:47
@AllanZyne AllanZyne requested a review from steffenlarsen June 17, 2025 01:47
@zhaomaosu zhaomaosu requested a review from Copilot June 17, 2025 01:51
Copilot

This comment was marked as outdated.

Sign in to view

yingcong-wu
yingcong-wu reviewed Jun 17, 2025
View reviewed changes
zhaomaosu
zhaomaosu reviewed Jun 17, 2025
View reviewed changes
zhaomaosu
zhaomaosu reviewed Jun 20, 2025
View reviewed changes
@AllanZyne AllanZyne requested a review from a team as a code owner June 20, 2025 10:00
AllanZyne
AllanZyne commented Jun 20, 2025
View reviewed changes
unified-runtime/source/loader/layers/sanitizer/msan/msan_buffer.cpp
@@ -63,38 +59,11 @@ ur_result_t EnqueueMemCopyRectHelper(
// loop call 2D memory copy function to implement it.
for (size_t i = 0; i < Region.depth; i++) {
ur_event_handle_t NewEvent{};
UR_CALL(getContext()->urDdiTable.Enqueue.pfnUSMMemcpy2D(
UR_CALL(msan::urEnqueueUSMMemcpy2D(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just comment: using APIs from msan_ddi so that the shadow and origin can be copied automatically

mdtoguchi
mdtoguchi reviewed Jun 20, 2025
View reviewed changes
@AllanZyne
Copy link
Contributor Author

Hi @intel/llvm-gatekeepers, this pr is ready to merge. Thanks!

@steffenlarsen
Copy link
Contributor

@intel/dpcpp-clang-driver-reviewers approval is required.

@yingcong-wu yingcong-wu requested a review from mdtoguchi June 23, 2025 07:50
@AllanZyne
Copy link
Contributor Author

Kindly ping @intel/llvm-gatekeepers, I've got dpcpp-clang-driver-reviewers's approve now

@uditagarwal97 uditagarwal97 merged commit fb071ab into sycl Jun 24, 2025
34 checks passed
@AllanZyne AllanZyne deleted the review/yang/feat_msan_origin branch June 24, 2025 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yingcong-wu yingcong-wu yingcong-wu left review comments

Copilot code review Copilot Copilot left review comments

@aarongreig aarongreig aarongreig approved these changes

@zhaomaosu zhaomaosu zhaomaosu approved these changes

@mdtoguchi mdtoguchi mdtoguchi approved these changes

@steffenlarsen steffenlarsen steffenlarsen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@AllanZyne @steffenlarsen @aarongreig @zhaomaosu @mdtoguchi @yingcong-wu 30C5 @uditagarwal97
0