8000 [SYCL][Driver] Mark DeviceLib option as deprecated by jinge90 · Pull Request #18581 · intel/llvm · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[SYCL][Driver] Mark DeviceLib option as deprecated #18581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Jun 25, 2025
Merged

[SYCL][Driver] Mark DeviceLib option as deprecated #18581

merged 19 commits into from
Jun 25, 2025

Conversation

jinge90
Copy link
Contributor
@jinge90 jinge90 commented May 21, 2025 •
edited
Loading

We decide to remove sycl device library jit link path, the 1st step is to mark all related driver option as 'deprecated' and cleared all tests using these options.

@jinge90 jinge90 requested a review from a team as a code owner May 21, 2025 08:08
@jinge90 jinge90 requested a review from mdtoguchi May 21, 2025 08:09
@jinge90
[SYCL][Driver] Mark DeviceLib option as deprecated
1cc5363 
Signed-off-by: jinge90 <ge.jin@intel.com>
mdtoguchi
mdtoguchi reviewed May 21, 2025
View reviewed changes
@jinge90 jinge90 requested a review from a team as a code owner May 30, 2025 06:05
@jinge90 jinge90 requested a review from sergey-semenov May 30, 2025 06:05
@jinge90 jinge90 temporarily deployed to WindowsCILock May 30, 2025 06:05 — with GitHub Actions Inactive
@jinge90 jinge90 temporarily deployed to WindowsCILock May 30, 2025 06:31 — with GitHub Actions Inactive
@jinge90
Clear tests using fsycl-device-lib-jit-link
f498bd5 
Signed-off-by: jinge90 <ge.jin@intel.com>
@jinge90 jinge90 temporarily deployed to WindowsCILock May 30, 2025 07:35 — with GitHub Actions Inactive
@jinge90
fix some unsupported
122b5da 
Signed-off-by: jinge90 <ge.jin@intel.com>
@jinge90 jinge90 temporarily deployed to WindowsCILock May 30, 2025 08:12 — with GitHub Actions Inactive
@jinge90 jinge90 temporarily deployed to WindowsCILock May 30, 2025 08:12 — with GitHub Actions Inactive
@jinge90 jinge90 temporarily deployed to WindowsCILock June 12, 2025 07:20 — with GitHub Actions Inactive
@jinge90
update no-unsupported-without-info list
598a38d 
Signed-off-by: jinge90 <ge.jin@intel.com>
@jinge90 jinge90 temporarily deployed to WindowsCILock June 12, 2025 07:50 — with GitHub Actions Inactive
@jinge90 jinge90 temporarily deployed to WindowsCILock June 12, 2025 07:50 — with GitHub Actions Inactive
@jinge90 jinge90 requested a review from mdtoguchi June 17, 2025 05:34
@jinge90 jinge90 temporarily deployed to WindowsCILock June 17, 2025 06:15 — with GitHub Actions Inactive
@jinge90 jinge90 temporarily deployed to WindowsCILock June 17, 2025 06:15 — with GitHub Actions Inactive
@jinge90
resolve conflicts
4726947 
Signed-off-by: jinge90 <ge.jin@intel.com>
@jinge90 jinge90 temporarily deployed to WindowsCILock June 17, 2025 07:05 — with GitHub Actions Inactive
@jinge90 jinge90 temporarily deployed to WindowsCILock June 17, 2025 07:32 — with GitHub Actions Inactive
@jinge90 jinge90 requested a review from mdtoguchi June 20, 2025 01:53
@jinge90 jinge90 temporarily deployed to WindowsCILock June 23, 2025 02:15 — with GitHub Actions Inactive
@jinge90 jinge90 temporarily deployed to WindowsCILock June 23, 2025 02:45 — with GitHub Actions Inactive
@jinge90 jinge90 temporarily deployed to WindowsCILock June 23, 2025 02:45 — with GitHub Actions Inactive
@jinge90 jinge90 temporarily deployed to WindowsCILock June 23, 2025 03:38 — with GitHub Actions Inactive
@jinge90 jinge90 temporarily deployed to WindowsCILock June 23, 2025 03:38 — with GitHub Actions Inactive
@jinge90
revert driver lit test
fb33baf 
Signed-off-by: jinge90 <ge.jin@intel.com>
@jinge90
revert sycl e2e changes
603d2b6 
Signed-off-by: jinge90 <ge.jin@intel.com>
@jinge90 jinge90 temporarily deployed to WindowsCILock June 25, 2025 03:33 — with GitHub Actions Inactive
@jinge90 jinge90 temporarily deployed to WindowsCILock June 25, 2025 03:33 — with GitHub Actions Inactive
@jinge90
apply more no-deprecated
0193eee 
Signed-off-by: jinge90 <ge.jin@intel.com>
@jinge90 jinge90 temporarily deployed to WindowsCILock June 25, 2025 03:41 — with GitHub Actions Inactive
@jinge90 jinge90 temporarily deployed to WindowsCILock June 25, 2025 04:08 — with GitHub Actions Inactive
@jinge90 jinge90 temporarily deployed to WindowsCILock June 25, 2025 04:08 — with GitHub Actions Inactive
@jinge90
fix windows build fail
c7f9f31 
Signed-off-by: jinge90 <ge.jin@intel.com>
@jinge90
Copy link
Contributor Author
jinge90 commented Jun 25, 2025

Hi, @intel/llvm-reviewers-runtime and @sergey-semenov
Could you take a look at this trivial pr? We mark "-fsycl-device-lib-jit-link" as deprecated, as it is used in some e2e tests, we have to add -Wno-drepcated to avoid some build failure in pre-ci.
Thanks very much.

@steffenlarsen steffenlarsen merged commit bcd88e7 into intel:sycl Jun 25, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdtoguchi mdtoguchi mdtoguchi approved these changes

@steffenlarsen steffenlarsen steffenlarsen approved these changes

@sergey-semenov sergey-semenov Awaiting requested review from sergey-semenov sergey-semenov is a code owner automatically assigned from intel/llvm-reviewers-runtime

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jinge90 @mdtoguchi @steffenlarsen
0