8000 [SYCL] Change which constructor is gated for devices by jbrodman · Pull Request #1183 · intel/llvm · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[SYCL] Change which constructor is gated for devices #1183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 27, 2020
Merged

[SYCL] Change which constructor is gated for devices #1183

merged 2 commits into from
Feb 27, 2020

Conversation

jbrodman
Copy link
Contributor

SYCL 1.2.1 includes a constructor for multi_ptr from T*, available on both the host and device. The current implementation disables this constructor on the host to avoid conflicting definitions for constructors using pointer_t and T*.

Making this constructor available enables implicit conversions between pointer types and multi_ptr classes, and addresses requests such as #849.

Signed-off-by: James Brodman james.brodman@intel.com

@jbrodman
Change which constructor is gated for devices
1aaf075 
Signed-off-by: James Brodman <james.brodman@intel.com>
Pennycook
Pennycook previously approved these changes Feb 25, 2020
View reviewed changes
@bader
Copy link
Contributor
bader commented Feb 25, 2020

@jbrodman, please, ignore failure in clang-format-check job. It seems to include irrelevant changes into the validated change.

@jbrodman
Copy link
Contributor Author

@jbrodman, please, ignore failure in clang-format-check job. It seems to include irrelevant changes into the validated change.

👍

@jbrodman
Also apply change to operator=
eac1990 
Signed-off-by: James Brodman <james.brodman@intel.com>
@jbrodman jbrodman requested review from Pennycook and bader February 26, 2020 15:13
@bader bader merged commit 401d174 into intel:sycl Feb 27, 2020
@Pennycook Pennycook mentioned this pull request Feb 28, 2020
Closed
@JackAKirk JackAKirk mentioned this pull request Nov 12, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pennycook Pennycook Pennycook approved these changes

@vladimirlaz vladimirlaz Awaiting requested review from vladimirlaz

@bader bader Awaiting requested review from bader

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jbrodman @bader @Pennycook
0