8000 [NFC] Remove erroneous debug output introduced in a pulldown by aelovikov-intel · Pull Request #8494 · intel/llvm · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[NFC] Remove erroneous debug output introduced in a pulldown #8494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 1, 2023
Merged

[NFC] Remove erroneous debug output introduced in a pulldown #8494

merged 1 commit into from
Mar 1, 2023

Conversation

aelovikov-intel
Copy link
Contributor

Manifsted itself as "TEST: flang" output during CMake invocation.

@aelovikov-intel
[NFC] Remove erroneous debug output introduced in a pulldown
a142e41 
Manifsted itself as "TEST: flang" output during CMake invocation.
@aelovikov-intel aelovikov-intel requested a review from a team as a code owner February 28, 2023 18:28
@aelovikov-intel aelovikov-intel temporarily deployed to aws February 28, 2023 21:53 — with GitHub Actions Inactive
@aelovikov-intel
Copy link
Contributor Author
aelovikov-intel commented Feb 28, 2023 •
edited
Loading

The failure (https://github.com/intel/llvm/actions/runs/4296187940) on

Timed Out Tests (1):
  SYCL-Unit :: scheduler/./SchedulerTests/17/19

TIMEOUT: SYCL-Unit :: scheduler/./SchedulerTests/17/19 (465 of 465)
******************** TEST 'SYCL-Unit :: scheduler/./SchedulerTests/17/19' FAILED ********************
Script(shard):
--
GTEST_OUTPUT=json:/__w/llvm/llvm/build/tools/sycl/unittests/scheduler/./SchedulerTests-SYCL-Unit-291055-17-19.json GTEST_SHUFFLE=0 GTEST_TOTAL_SHARDS=19 GTEST_SHARD_INDEX=17 /__w/llvm/llvm/build/tools/sycl/unittests/scheduler/./SchedulerTests
--

Note: This is test shard 18 of 19.
[==========] Running 2 tests from 2 test suites.
[----------] Global test environment set-up.
[----------] 1 test from SchedulerTest
[ RUN      ] SchedulerTest.QueueFlushing
[       OK ] SchedulerTest.QueueFlushing (0 ms)
[----------] 1 test from SchedulerTest (0 ms total)

[----------] 1 test from DependsOnTests
[ RUN      ] DependsOnTests.EnqueueNoMemObjDoubleKernelDepHost
[       OK ] DependsOnTests.EnqueueNoMemObjDoubleKernelDepHost (1 ms)
[----------] 1 test from DependsOnTests (1 ms total)

[----------] Global test environment tear-down
[==========] 2 tests from 2 test suites ran. (1 ms total)
[  PASSED  ] 2 tests.

--
exit: -9
--
Reached timeout of 600 seconds

can't be related but failing check-sycl results in llvm-test-suite not being run at all, so restarting the whole testing. Writing this comment so that a future github search on the test (if it will fail elsewhere sometime) would point to this run.

@bader
Copy link
Contributor
bader commented Feb 28, 2023

The failure on

Timed Out Tests (1):
  SYCL-Unit :: scheduler/./SchedulerTests/17/19

can't be related but failing check-sycl results in llvm-test-suite not being run at all, so restarting the whole testing. Writing this comment so that a future github search on the test (if it will fail elsewhere sometime) would point to this run.

FYI: hit a failure in check-sycl recently too. https://github.com/intel/llvm/actions/runs/4289215301/jobs/7472100523
Turned out to be a bug in the test - #8485 (comment).

I suggest you either investigate this failure right away or file a bug report to investigate it later.

@aelovikov-intel aelovikov-intel mentioned this pull request Feb 28, 2023
Closed
@aelovikov-intel aelovikov-intel temporarily deployed to aws March 1, 2023 01:07 — with GitHub Actions Inactive
@aelovikov-intel
Copy link
Contributor Author
aelovikov-intel commented Mar 1, 2023 •
edited
Loading

SYCL :: Basic/reqd_work_group_size.cpp failing on HIP is tracked in #8146

There is some infrastructure issue with CUDA testing in this pre-commit CI, but I don't think this small change deserves yet another round of re-testing putting pressure on our CI machines pool.

@aelovikov-intel
Copy link
Contributor Author

@dpcpp-tools-reviewers can I get this approved and merged please?

sarnex
sarnex approved these changes Mar 1, 2023
View reviewed changes
Copy link
Contributor
@sarnex sarnex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Relinquishing to Alexey's approval, I don't have merge permission though, sorry

@AlexeySachkov AlexeySachkov merged commit 7d03bda into intel:sycl Mar 1, 2023
@bader
Copy link
Contributor
bader commented Mar 1, 2023

There are not results for "Linux / [AWS] CUDA LLVM Test Suite". Please, file a bug report for this issue.

@aelovikov-intel aelovikov-intel temporarily deployed to aws March 2, 2023 12:24 — with GitHub Actions Inactive
@aelovikov-intel aelovikov-intel deleted the remove-test-flang branch April 7, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bader bader bader approved these changes

@sarnex sarnex sarnex approved these changes

@maksimsab maksimsab Awaiting requested review from maksimsab

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aelovikov-intel @bader @sarnex @AlexeySachkov
0