[ESIMD] Fix usage of uninitialized field ESIMDVerifier::ForceStateles… #8000
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v-klochkov
commented
Jan 13, 2023
| @@ -187,4 +187,6 @@ INITIALIZE_PASS_BEGIN(ESIMDVerifier, DEBUG_TYPE, "ESIMD-specific IR verifier", | |||
| INITIALIZE_PASS_END(ESIMDVerifier, DEBUG_TYPE, "ESIMD-specific IR verifier", | |||
| false, false) | |||
|
|
|||
| ModulePass *llvm::createESIMDVerifierPass() { return new ESIMDVerifier(); } | |||
| ModulePass *llvm::createESIMDVerifierPass(bool MayNeedForceStatelessMemModeAPI) { | |||
There was a problem hiding this comment.
Before this PR: Creation of ESIMDVerifier() without arguments left the field 'ForceStatelessMem' uninitialized and thus having random value.
v-klochkov
commented
Jan 13, 2023
| @@ -173,7 +173,7 @@ struct ESIMDVerifier : public ModulePass { | |||
| } | |||
|
|
|||
| bool runOnModule(Module &M) override { | |||
| ESIMDVerifierImpl(M, ForceStatelessMem).verify(); | |||
| ESIMDVerifierImpl(M, MayNeedForceStatelessMemModeAPI).verify(); | |||
There was a problem hiding this comment.
Before this PR: ForceStatelessMem field was used uninitialized here.
…sMem The field was properly initialized in 'ESIMDVerifierPass` struct, but not in `ESIMDVerifier`. The first one gets the proper/guarantted value from LangOpts.SYCLESIMDForceStatelessMem, while the second(i.e. ESIMDVerifier) could not do the same as it is initialized from llvm::createESIMDVerifierPass() Fixing this issue showed that those SYCL methods that are allowed with -fsycl-esimd-force-stateless-mem, can potentially and legally be used in some other modes, for example, when used in LLVM IR consumed by 'opt' component. Thus the meaning and name of the corresponding fields in ESIMDVerifier and ESIMDVerifierPass structs were renamed from ForceStatelessMem to MayNeedForceStatelessMemModeAPI. Signed-off-by: Vyacheslav N Klochkov <vyacheslav.n.klochkov@intel.com>
f5bc63c to
53f9622
Compare
sarnex
approved these changes
Jan 13, 2023
fineg74
approved these changes
Jan 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…sMem
The field was properly initialized in 'ESIMDVerifierPass
struct, but not inESIMDVerifier`.The first one gets the proper/guarantted value from LangOpts.SYCLESIMDForceStatelessMem, while the second(i.e. ESIMDVerifier) could not do the same as it is initialized from
llvm::createESIMDVerifierPass()
Fixing this issue showed that those SYCL methods that are allowed with -fsycl-esimd-force-stateless-mem, can potentially and legally be used in some other modes, for example, when used in LLVM IR consumed by 'opt' component. Thus the meaning and name of the corresponding fields in ESIMDVerifier and ESIMDVerifierPass structs were renamed from ForceStatelessMem to MayNeedForceStatelessMemModeAPI.
Signed-off-by: Vyacheslav N Klochkov vyacheslav.n.klochkov@intel.com