[SYCL] Generate and install stripped PDBs for SYCL libraries #4915
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<
8000
div class="d-flex flex-md-row flex-column">
Adds stripped PDB files for SYCL library and the PI plugins when building with MSVC. Full PDB files will also be generated, but only the stripped variants will be installed. The stripped PDB files will only be generated and installed if the used linker supports the /PDBSTRIPPED options. LLD does not currently support this option. If the stripped PDB is not generated, no PDB files are installed for the SYCL libraries and PI plugins. Signed-off-by: Steffen Larsen <steffen.larsen@intel.com>
Signed-off-by: Steffen Larsen <steffen.larsen@intel.com>
s-kanaev
approved these changes
Nov 16, 2021
Comment on lines
+52
to
+53
| # Install stripped PDB | ||
| add_stripped_pdb(pi_cuda) |
There was a problem hiding this comment.
Should this also be done for hip plugin?
There was a problem hiding this comment.
To my knowledge, the HIP plugin is not currently supported on Windows. As soon as it is, I imagine the CMake will include this entire MSVC section, adjusted for the HIP plugin.
|
@againull , @smaslov-intel , a friendly ping on review |
smaslov-intel
approved these changes
Nov 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds stripped PDB files for SYCL library and the PI plugins when building with MSVC. Full PDB files will also be generated, but only the stripped variants will be installed.
The stripped PDB files will only be generated and installed if the used linker supports the /PDBSTRIPPED option. LLD does not currently support this option. If the stripped PDB is not generated, no PDB files are installed for the SYCL libraries and PI plugins.