8000 [SYCL] Restore the correct initialization for _statically_coalesce_val by dm-vodopyanov · Pull Request #4206 · intel/llvm · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[SYCL] Restore the correct initialization for _statically_coalesce_val #4206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 29, 2021
Merged

[SYCL] Restore the correct initialization for _statically_coalesce_val #4206

merged 1 commit into from
Jul 29, 2021

Conversation

dm-vodopyanov
Copy link
Contributor

Patch #3957 introduces _statically_coalesce_val in fpga_lsu.cpp like this:

_GetValue<statically_coalesce_impl<1>, _mem_access_params...>::value;

During merge conflict resolution in #4014 it was change accidentally to

_GetValue<statically_coalesce_impl<0>, _mem_access_params...>::value;

Restoring the right value.

@dm-vodopyanov
[SYCL] Restore the correct initialization for _statically_coalesce_val
ece18f2 
Patch intel#3957 introduces
`_statically_coalesce_val` in fpga_lsu.cpp like this:

```
_GetValue<statically_coalesce_impl<1>, _mem_access_params...>::value;
```

During merge conflict resolution in
intel#4014 it was change accidentally to

```
_GetValue<statically_coalesce_impl<0>, _mem_access_params...>::value;
```

Restoring the right value.
@dm-vodopyanov dm-vodopyanov requested a review from a team as a code owner July 28, 2021 13:24
shuoniu-intel
shuoniu-intel reviewed Jul 28, 2021
View reviewed changes
Copy link
Contributor
@shuoniu-intel shuoniu-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dm-vodopyanov
Copy link
Contributor Author

@v-klochkov is on vacation, @intel/llvm-reviewers-runtime, can someone review?

s-kanaev
s-kanaev approved these changes Jul 29, 2021
View reviewed changes
Copy link
Contributor
@s-kanaev s-kanaev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bader bader merged commit 3dc0f4d into intel:sycl Jul 29, 2021
zahiraam pushed a commit to zahiraam/llvm-1 that referenced this pull request Aug 2, 2021
@dm-vodopyanov @zahiraam
[SYCL] Restore the correct initialization for _statically_coalesce_val (
2842545 
intel#4206)

Patch intel#3957 introduces
`_statically_coalesce_val` in fpga_lsu.cpp like this:

```
_GetValue<statically_coalesce_impl<1>, _mem_access_params...>::value;
```

During merge conflict resolution in
intel#4014 it was change accidentally to

```
_GetValue<statically_coalesce_impl<0>, _mem_access_params...>::value;
```

Restoring the right value.
@dm-vodopyanov dm-vodopyanov deleted the private/dvodopya/restore-right-_statically_coalesce_val-initialization branch February 10, 2022 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shuoniu-intel shuoniu-intel shuoniu-intel left review comments

@s-kanaev s-kanaev s-kanaev approved these changes

@v-klochkov v-klochkov Awaiting requested review from v-klochkov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dm-vodopyanov @s-kanaev @shuoniu-intel @bader
0