-
Notifications
You must be signed in to change notification settings - Fork 769
[SYCL] Adds info query for atomic_memory_order_capabilities on device and context #4105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
bader
merged 4 commits into
intel:sycl
from
steffenlarsen:steffen/memory_order_capabilities
Jul 21, 2021
Merged
[SYCL] Adds info query for atomic_memory_order_capabilities on device and context #4105
bader
merged 4 commits into
intel:sycl
from
steffenlarsen:steffen/memory_order_capabilities
Jul 21, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smaslov-intel
previously approved these changes
Jul 14, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PI-related changes LGTM
@steffenlarsen, please, align changes with d703f57. |
… and context Implements support for device::info::atomic_memory_order_capabilities and context::info::atomic_memory_order_capabilities. The corresponding PI query is only implemented for the PI CUDA backend and host. Signed-off-by: Steffen Larsen <steffen.larsen@codeplay.com>
Signed-off-by: Steffen Larsen <steffen.larsen@codeplay.com>
Signed-off-by: Steffen Larsen <steffen.larsen@codeplay.com>
7b8fef9
to
61310e3
Compare
I have rebased the changes. I hope this was what you wanted. |
bader
previously approved these changes
Jul 19, 2021
Pennycook
reviewed
Jul 19, 2021
Signed-off-by: Steffen Larsen <steffen.larsen@codeplay.com>
Pennycook
approved these changes
Jul 19, 2021
@intel/llvm-reviewers-cuda, @smaslov-intel, @intel/llvm-reviewers-runtime, ping. |
smaslov-intel
approved these changes
Jul 21, 2021
alexbatashev
added a commit
to alexbatashev/llvm
that referenced
this pull request
Jul 22, 2021
…ackend_plugin * upstream/sycl: (26 commits) [SPIR-V][NFC] Move non-upstreamed FuncParam decorations into internal:: (intel#4138) [SYCL] Move free function queries to experimental namespace (intel#4090) [SYCL][XPTI] Enable PI calls notifications with arguments (intel#4148) [SYCL] Revert queue::wait() to its old behaviour with Level Zero (intel#4153) [SYCL] Add missing <cstring> header to spirv.hpp (intel#4157) [SYCL] Adds info query for atomic_memory_order_capabilities on device and context (intel#4105) [SYCL] Improve performance of generic shuffles (intel#3815) [SYCL] Fix the error with namespaces caused during rebase of intel#4014 (intel#4151) [ESIMD] Fix 'ambiguous operator' error with length 1 simd operands (intel#4149) [libdevice][NFC] Fix libdevice dependencies list (intel#4130) [SPIR-V] Reland Encode debug info producer in SPIR-V (intel#4082) [SYCL][ROCm] Add ROCm support to get_device_count_by_type (intel#4113) [SYCL] Fix sRGB device info (intel#4145) [SYCL][ROCm] Fix kernel launch with multiple dimensions (intel#4063) [SYCL][ROCm] Fix compilation for AMD GPU with -fsycl-dead-args-optimization (intel#4126) [SYCL][Level Zero] Enable multi-CCS support. (intel#4038) [SYCL] Pass bound arch to unbundler (intel#4112) [ESIMD][doc] Added documentation for some ESIMD math APIs (intel#3995) [ESIMD] rename gather4/scatter4 to gather_rgba/scatter_rgba (intel#4120) [SYCL][NFC] Remove unused variable. (intel#4131) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements support for
device::info::atomic_memory_order_capabilities
andcontext::info::atomic_memory_order_capabilities
. The corresponding PI query is only implemented for the PI CUDA backend and host.Additionally, these changes reverse the dependency between
sycl/include/CL/sycl/ONEAPI/atomic_enums.hpp
andsycl/include/CL/sycl/memory_enums.hpp
and replace all uses ofsycl::ONEAPI::memory_order
andsycl::ONEAPI::memory_scope
withsycl::memory_order
andsycl::memory_scope
respectively.