Update word count overage to a warning rather than error #743
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jeff-phillips-18 Two questions:
|
|
@megan-hall Thanks! Forgot to change the context selection. Will update shortly. |
81d9eb8 to
33cd24a
Compare
|
@megan-hall Updated and added a screen shot above. And yes, the user can now submit regardless of the word counts for question-and-answer pairs or context. |
Signed-off-by: Jeffrey Phillips <jephilli@redhat.com>
33cd24a to
2def1dc
Compare
|
@Misjohns @megan-hall @beaumorley Merging this PR, but if you have any review comment, please open another issue, so that we can take care of those in follow-up PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change error visuals/text to warnings for seed example word counts. Allow saving when over the recommended word count limits.
Update the seed example validations when reaching the review step so that errors are shown correctly when navigating back to the seed example step.
Screen shots
/cc @kaedward