8000 Contribution wizard content updates by jeff-phillips-18 · Pull Request #724 · instructlab/ui · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Contribution wizard content updates #724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 16, 2025
Merged

Contribution wizard content updates #724

merged 1 commit into from
Apr 16, 2025

Conversation

jeff-phillips-18
Copy link
Collaborator
@jeff-phillips-18 jeff-phillips-18 commented Apr 14, 2025 •
edited
Loading

Fixes [Dev] Contribution wizard content updates based on review

Description

Update content of contribution wizard screens based on Content design review

Screen shots

Knowledge: Details

image

Knowledge: Edit contributor information

image

Knowledge: Details popover

image

Knowledge: Upload documents

image

Knowledge: Upload from git repository

image

Knowledge: Upload file overwrite confirmation

image

Knowledge: Uploading file

image

Knowledge: Source attribution

image

Knowledge: Source attribution popovers

image

Knowledge: Create seed data (1)

image

Knowledge: Create seed data (2)

image

Knowledge: Review (1)

image

Knowledge: Review (2)

image

Skill: Details

image

Skill: Create seed data

image

Skill: Create seed data (2)

image

Skill: Source attribution

image

Skill: Review (1)

image

Skill: Review (2)

image

/cc @kaedward

vishnoianil
vishnoianil reviewed Apr 16, 2025
View reviewed changes
src/components/Contribute/ReviewSubmission/ReviewSubmission.tsx Outdated
title={`${isSkillContribution ? 'Skill' : 'Knowledge'} Information`}
descriptionText={`Brief information about the ${isSkillContribution ? 'skill' : 'knowledge'}`}
title="Contribution information"
descriptionText="Brief brief summary of your contribution, and the directory path for your reference documents."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo -> double Brief?

vishnoianil
vishnoianil approved these changes Apr 16, 2025
View reviewed changes
Copy link
Member
@vishnoianil vishnoianil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeff-phillips-18
Contribution wizard content updates
85711f2 
Signed-off-by: Jeffrey Phillips <jephilli@redhat.com>
@jeff-phillips-18 jeff-phillips-18 merged commit ee8724f into instructlab:main Apr 16, 2025
5 checks passed
@kaedward
Copy link

@jeff-phillips-18 Looks good overall, I just noticed a few issues:

image
Suggested text:
"Overwrite file?
A file with the name file-name has already been uploaded in this contribution. Uploading the new file will overwrite the existing one.

image
"Select Context from Files" --> "Select context from files"
"Seed Example 1" --> "Seed example 1" (Same for following seed examples)

image
(1-4 apply to their corresponding labels in prev. steps + popovers)

  1. Title --> Resource title
  2. Link to work --> Resource link
  3. License of the work --> Resource license
  4. Examples --> Seed examples
  5. [YAML/Attribution files] --> [Download contribution details]

image
The section titles (not sure what these are actually called) seem a little off in this screenshot. "Review" kind of blends in with the rest of the field labels, "Contributor details" is smaller than "Contributors", etc. @Misjohns, does this look OK to you?

@Misjohns
Copy link
Collaborator
Misjohns commented Apr 22, 2025 •
edited
Loading

@jeff-phillips-18 The fonts do look off. I tried to callout the different sizes for reference. Also, you can look at Figma styles here: https://www.figma.com/design/KFWNOTiYiMPIX6vLWnL6Bt/E2E-Flow?node-id=22-22031&t=fKgCFJ8nh3oaCmwu-4
image

@jeff-phillips-18 jeff-phillips-18 mentioned this pull request Apr 23, 2025
Closed
@jeff-phillips-18 jeff-phillips-18 deleted the wizard-content branch April 23, 2025 13:41
@jeff-phillips-18 jeff-phillips-18 mentioned this pull request Apr 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vishnoianil vishnoianil vishnoianil approved these changes

@Misjohns Misjohns Awaiting requested review from Misjohns

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Dev] Contribution wizard content updates based on review
4 participants
@jeff-phillips-18 @kaedward @Misjohns @vishnoianil
0