8000 Fix knowledge submission issue by vishnoianil · Pull Request #214 · instructlab/ui · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix knowledge submission issue #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Fix knowledge submission issue #214

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9b0be63
Fix knowledge contribution submission
vishnoianil Sep 27, 2024
951a4ad
Use the latest image. Latest tag points to the latest release
vishnoianil Sep 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions deploy/k8s/overlays/openshift/prod/kustomization.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ patches:
patch: |-
- op: replace
path: /spec/template/spec/containers/0/image
value: quay.io/instructlab-ui/ui:v1.0.0-beta # Override this image if you want to use a different UI image
value: quay.io/instructlab-ui/ui:latest #Override this image if you want to use a different UI image

# Override the pathservice image for Openshift production deployment
- target:
Expand All @@ -45,4 +45,4 @@ patches:
patch: |-
- op: replace
path: /spec/template/spec/containers/0/image
value: quay.io/instructlab-ui/pathservice:v1.0.0-beta # Override this image if you want to use a different pathservice image
value: quay.io/instructlab-ui/pathservice:latest #Override this image if you want to use a different pathservice image
36 changes: 18 additions & 18 deletions src/components/Contribute/Knowledge/index.tsx
View file
Open in desktop
10000
Original file line number Diff line number Diff line change
Expand Up @@ -225,46 +225,46 @@ export const KnowledgeForm: React.FunctionComponent<KnowledgeFormProps> = ({ kno
const contextStr = context.trim();
if (contextStr.length == 0) {
setDisableAction(true);
return { errorMsg: 'Context is required', context: ValidatedOptions.error };
return { msg: 'Context is required', status: ValidatedOptions.error };
}
const tokens = contextStr.split(/\s+/);
if (tokens.length > 0 && tokens.length <= 500) {
setDisableAction(!checkKnowledgeFormCompletion(knowledgeFormData));
return { errorMsg: '', context: ValidatedOptions.success };
return { msg: 'Valid Input', status: ValidatedOptions.success };
}
setDisableAction(true);
const errorMsg = 'Context must be less than 500 words. Current word count: ' + tokens.length;
return { errorMsg: errorMsg, context: ValidatedOptions.error };
return { msg: errorMsg, status: ValidatedOptions.error };
};

const validateQuestion = (question: string) => {
const questionStr = question.trim();
if (questionStr.length == 0) {
setDisableAction(true);
return { errorMsg: 'Question is required', context: ValidatedOptions.error };
return { msg: 'Question is required', status: ValidatedOptions.error };
}
const tokens = questionStr.split(/\s+/);
if (tokens.length > 0 && tokens.length < 250) {
setDisableAction(!checkKnowledgeFormCompletion(knowledgeFormData));
return { errorMsg: '', context: ValidatedOptions.success };
return { msg: 'Valid input', status: ValidatedOptions.success };
}
setDisableAction(true);
return { errorMsg: 'Question must be less than 250 words. Current word count: ' + tokens.length, context: ValidatedOptions.error };
return { msg: 'Question must be less than 250 words. Current word count: ' + tokens.length, status: ValidatedOptions.error };
};

const validateAnswer = (answer: string) => {
const answerStr = answer.trim();
if (answerStr.length == 0) {
setDisableAction(true);
return { errorMsg: 'Answer is required', context: ValidatedOptions.error };
return { msg: 'Answer is required', status: ValidatedOptions.error };
}
const tokens = answerStr.split(/\s+/);
if (tokens.length > 0 && tokens.length < 250) {
setDisableAction(!checkKnowledgeFormCompletion(knowledgeFormData));
return { errorMsg: '', context: ValidatedOptions.success };
return { msg: 'Valid input', status: ValidatedOptions.success };
}
setDisableAction(true);
return { errorMsg: 'Answer must be less than 250 words. Current word count: ' + tokens.length, context: ValidatedOptions.error };
return { msg: 'Answer must be less than 250 words. Current word count: ' + tokens.length, status: ValidatedOptions.error };
};

const handleContextInputChange = (seedExampleIndex: number, contextValue: string): void => {
Expand All @@ -283,11 +283,11 @@ export const KnowledgeForm: React.FunctionComponent<KnowledgeFormProps> = ({ kno
const handleContextBlur = (seedExampleIndex: number): void => {
const updatedSeedExamples = seedExamples.map((seedExample: SeedExample, index: number): SeedExample => {
if (index === seedExampleIndex) {
const { errorMsg, context } = validateContext(seedExample.context);
const { msg, status } = validateContext(seedExample.context);
return {
...seedExample,
isContextValid: context,
validationError: errorMsg
isContextValid: status,
validationError: msg
};
}
return seedExample;
Expand Down Expand Up @@ -323,11 +323,11 @@ export const KnowledgeForm: React.FunctionComponent<KnowledgeFormProps> = ({ kno
...seedExample,
questionAndAnswers: seedExample.questionAndAnswers.map((questionAndAnswerPair: QuestionAndAnswerPair, index: number) => {
if (index === questionAndAnswerIndex) {
const { errorMsg, context } = validateQuestion(questionAndAnswerPair.question);
const { msg, status } = validateQuestion(questionAndAnswerPair.question);
return {
...questionAndAnswerPair,
isQuestionValid: context,
questionValidationError: errorMsg
isQuestionValid: status,
questionValidationError: msg
};
}
return questionAndAnswerPair;
Expand Down Expand Up @@ -366,11 +366,11 @@ export const KnowledgeForm: React.FunctionComponent<KnowledgeFormProps> = ({ kno
...seedExample,
questionAndAnswers: seedExample.questionAndAnswers.map((questionAndAnswerPair: QuestionAndAnswerPair, index: number) => {
if (index === questionAndAnswerIndex) {
const { errorMsg, context } = validateAnswer(questionAndAnswerPair.answer);
const { msg, status } = validateAnswer(questionAndAnswerPair.answer);
return {
...questionAndAnswerPair,
isAnswerValid: context,
answerValidationError: errorMsg
isAnswerValid: status,
answerValidationError: msg
};
}
return questionAndAnswerPair;
Expand Down
0